From: Thomas Huth <thuth@redhat.com>
To: David Hildenbrand <david@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>, Alexander Graf <agraf@suse.de>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.11 1/3] s390x: fix storing CPU status (again)
Date: Thu, 16 Nov 2017 21:45:19 +0100 [thread overview]
Message-ID: <79c05cdb-6aec-b2bf-f4b9-167e8df6214f@redhat.com> (raw)
In-Reply-To: <20171116170526.12643-2-david@redhat.com>
On 16.11.2017 18:05, David Hildenbrand wrote:
> Looks like the last fix + cleanup introduced another bug. (for now Linux
> guests don't seem to care) - we store the crs into ars.
>
> Fixes: 947a38bd6f13 ("s390x/kvm: fix and cleanup storing CPU status")
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index f78983dd6a..246ba20f0d 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -279,7 +279,7 @@ int s390_store_status(S390CPU *cpu, hwaddr addr, bool store_arch)
> sa->ars[i] = cpu_to_be32(cpu->env.aregs[i]);
> }
> for (i = 0; i < 16; ++i) {
> - sa->ars[i] = cpu_to_be64(cpu->env.cregs[i]);
> + sa->crs[i] = cpu_to_be64(cpu->env.cregs[i]);
> }
>
> cpu_physical_memory_unmap(sa, len, 1, len);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-11-16 20:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 17:05 [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308 David Hildenbrand
2017-11-16 17:05 ` [Qemu-devel] [PATCH v1 for-2.11 1/3] s390x: fix storing CPU status (again) David Hildenbrand
2017-11-16 20:45 ` Thomas Huth [this message]
2017-11-16 20:58 ` Christian Borntraeger
2017-11-16 17:05 ` [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG) David Hildenbrand
2017-11-16 17:37 ` Alex Bennée
2017-11-16 17:52 ` David Hildenbrand
2017-11-16 18:12 ` Alex Bennée
2017-11-16 18:24 ` David Hildenbrand
2017-11-16 18:14 ` Alex Bennée
2017-11-16 17:47 ` David Hildenbrand
2017-11-16 20:57 ` Christian Borntraeger
2017-11-16 21:42 ` David Hildenbrand
2017-11-16 17:05 ` [Qemu-devel] [PATCH v1 for-2.11 3/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG) David Hildenbrand
2017-11-16 20:54 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2017-11-16 17:23 ` [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308 Cornelia Huck
2017-11-16 17:32 ` David Hildenbrand
2017-11-16 20:55 ` Christian Borntraeger
2017-11-17 8:07 ` Cornelia Huck
2017-11-17 8:10 ` Cornelia Huck
2017-11-17 8:38 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79c05cdb-6aec-b2bf-f4b9-167e8df6214f@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).