From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Claudio Fontana <cfontana@suse.de>
Subject: Re: [PATCH] tests: add missing genh dependency
Date: Fri, 11 Sep 2020 16:28:01 +0200 [thread overview]
Message-ID: <79c2c28d-2f30-1a7f-5006-56a86dd42951@redhat.com> (raw)
In-Reply-To: <20200911134221.46636-3-pbonzini@redhat.com>
On 9/11/20 3:42 PM, Paolo Bonzini wrote:
> Fix high-parallelism builds by forcing all generated headers
> to be created before tests are compiled.
FYI I had this problem too (simply building with -j8)
simply adding a new qapi/file.json.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reported-by: Claudio Fontana <cfontana@suse.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/meson.build b/tests/meson.build
> index 3683512dca..e2b915ea8f 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -56,7 +56,7 @@ test_qapi_files = custom_target('Test QAPI files',
> # perhaps change qapi_gen to replace / with _, like Meson itself does?
> subdir('include')
>
> -libtestqapi = static_library('testqapi', sources: [test_qapi_files, test_qapi_outputs_extra])
> +libtestqapi = static_library('testqapi', sources: [test_qapi_files, genh, test_qapi_outputs_extra])
> testqapi = declare_dependency(link_with: libtestqapi)
>
> testblock = declare_dependency(dependencies: [block], sources: 'iothread.c')
> @@ -223,7 +223,7 @@ foreach test_name, extra: tests
> src += test_ss.all_sources()
> deps += test_ss.all_dependencies()
> endif
> - exe = executable(test_name, src, dependencies: deps)
> + exe = executable(test_name, src, genh, dependencies: deps)
>
> test(test_name, exe,
> depends: test_deps.get(test_name, []),
>
prev parent reply other threads:[~2020-09-11 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 13:42 [PATCH] tests: add missing genh dependency Paolo Bonzini
2020-09-11 13:57 ` Claudio Fontana
2020-09-11 14:28 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79c2c28d-2f30-1a7f-5006-56a86dd42951@redhat.com \
--to=philmd@redhat.com \
--cc=cfontana@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).