qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] .travis.yml: Add description to each job
Date: Sun, 26 Jan 2020 08:54:51 +0100	[thread overview]
Message-ID: <79c2d168-498c-88eb-0857-4c3b195f7e32@redhat.com> (raw)
In-Reply-To: <20200125183135.28317-1-f4bug@amsat.org>

On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote:
> The NAME variable can be used to describe nicely a job (see [*]).
> As we currently have 32 jobs, use it. This helps for quickly
> finding a particular job.
> 
>   before: https://travis-ci.org/qemu/qemu/builds/639887646
>   after: https://travis-ci.org/philmd/qemu/builds/641795043

Very good idea, correlating a job in the GUI to an entry in the yml file
was really a pain, so far.

> [*] https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------
>  1 file changed, 67 insertions(+), 34 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 6c1038a0f1..d68e35a2c5 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -94,24 +94,28 @@ after_script:
>  
>  matrix:
>    include:
> -    - env:
> +    - name: "[x86] GCC static (user)"

Could you please drop the [x86] and other architectures from the names?
Travis already lists the build architecture in the job status page, so
this information is redundant.

[...]
>      # Alternate coroutines implementations are only really of interest to KVM users
>      # However we can't test against KVM on Travis so we can only run unit tests
> -    - env:
> +    - name: "[x86] check-unit coroutine=ucontext"
> +      env:
>          - CONFIG="--with-coroutine=ucontext --disable-tcg"
>          - TEST_CMD="make check-unit -j3 V=1"
>  
>  
> -    - env:
> +    - name: "[x86] check-unit coroutine=sigaltstack"
> +      env:
>          - CONFIG="--with-coroutine=sigaltstack --disable-tcg"
>          - TEST_CMD="make check-unit -j3 V=1"
>

Off-topic to your patch, but aren't coroutines something that is only
used in the softmmu targets? If so, we could add --disable-user to the
above two builds to speed things up a little bit.

>  
>      # Check we can build docs and tools (out of tree)
> -    - env:
> +    - name: "[x86] tools and docs"
> +      env:
>          - BUILD_DIR="out-of-tree/build/dir" SRC_DIR="../../.."

Also off-topic, but I think we can now remove the above line and fix the
comment - since all builds are now out-of-tree anyway, see commit
bc4486fb233573e.


> @@ -250,7 +271,8 @@ matrix:
>  
>  
>      # Python builds
> -    - env:
> +    - name: "[x86] GCC Python 3.5 (x86_64-softmmu)"
> +      env:

Off-topic again:
Python 3.5 is the default on xenial, and since we stopped using Python
2.7, I think we could remove this job now.

We could add some jobs with Bionic + Python 3.7 and 3.8 instead.

>          - CONFIG="--target-list=x86_64-softmmu"
>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>        language: python
> @@ -258,7 +280,8 @@ matrix:
>          - "3.5"
>  
>  
> -    - env:
> +    - name: "[x86] GCC Python 3.6 (x86_64-softmmu)"
> +      env:
>          - CONFIG="--target-list=x86_64-softmmu"
>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>        language: python

 Thomas



  reply	other threads:[~2020-01-26  7:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-25 18:31 [PATCH] .travis.yml: Add description to each job Philippe Mathieu-Daudé
2020-01-26  7:54 ` Thomas Huth [this message]
2020-01-28 12:55   ` Alex Bennée
2020-01-28 13:18     ` Philippe Mathieu-Daudé
2020-01-28 13:33       ` Wainer dos Santos Moschetta
2020-01-29  7:20         ` Thomas Huth
2020-01-29  7:27           ` Philippe Mathieu-Daudé
2020-01-29  7:34             ` Thomas Huth
2020-01-29  8:20               ` Philippe Mathieu-Daudé
2020-01-29  7:38     ` Thomas Huth
2020-01-28 13:20   ` Wainer dos Santos Moschetta
2020-01-29  7:31     ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79c2d168-498c-88eb-0857-4c3b195f7e32@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).