Re: [PATCH] rust: cell: add full example of declaring a SysBusDevice

[Paolo Bonzini <pbonzini@redhat.com>]

On 3/4/25 18:04, Zhao Liu wrote:
>> +//! struct PL061Device {
> 
> Maybe PL061State?
> 
>> +//!     parent_obj: ParentField<SysBusDevice>,
>> +//!
>> +//!     // Configuration is read-only after initialization
>> +//!     pullups: u32,
>> +//!     pulldowns: u32,
>> +//!
>> +//!     // Same for sub-objects of the device
>> +//!     out: [Owned<IRQState>; N_GPIOS],
> 
> Should this be InterruptSource type?
> 
> Just have a quick look at pl061.c:
> 
> qdev_init_gpio_out(dev, s->out, N_GPIOS);
> 
> So in Rust side, `out` would be initialized by
> DeviceMethods::init_gpio_out().
> 
> 
> Others are fine for me ~ with above nits fixed,
> 
> Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Yes, all good points.  Looks like we're set for 10.0 soft freeze. :)

Paolo