From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzOTS-0000Y5-LW for qemu-devel@nongnu.org; Wed, 26 Oct 2016 09:42:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzOTO-0002xv-Br for qemu-devel@nongnu.org; Wed, 26 Oct 2016 09:42:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48164) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzOTO-0002xj-3u for qemu-devel@nongnu.org; Wed, 26 Oct 2016 09:42:30 -0400 References: <1476792613-11712-1-git-send-email-zhang.zhanghailiang@huawei.com> <1476792613-11712-18-git-send-email-zhang.zhanghailiang@huawei.com> <20161026060746.GQ1679@amit-lp.rh> From: Eric Blake Message-ID: <79ca80e4-e13a-c0bf-c7d9-ec6cf0f8c7df@redhat.com> Date: Wed, 26 Oct 2016 08:42:27 -0500 MIME-Version: 1.0 In-Reply-To: <20161026060746.GQ1679@amit-lp.rh> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MJ5NVfLdctq1GFhk8xfeUVVEgvKSqNLrQ" Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah , zhanghailiang Cc: xiecl.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com, quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, Gonglei This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MJ5NVfLdctq1GFhk8xfeUVVEgvKSqNLrQ From: Eric Blake To: Amit Shah , zhanghailiang Cc: xiecl.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com, quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, Gonglei Message-ID: <79ca80e4-e13a-c0bf-c7d9-ec6cf0f8c7df@redhat.com> Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature References: <1476792613-11712-1-git-send-email-zhang.zhanghailiang@huawei.com> <1476792613-11712-18-git-send-email-zhang.zhanghailiang@huawei.com> <20161026060746.GQ1679@amit-lp.rh> In-Reply-To: <20161026060746.GQ1679@amit-lp.rh> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/26/2016 01:07 AM, Amit Shah wrote: > On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: >> configure --enable-colo/--disable-colo to switch COLO >> support on/off. >> COLO feature is enabled by default. >> >> Signed-off-by: zhanghailiang >> Signed-off-by: Li Zhijian >> Signed-off-by: Gonglei >> Reviewed-by: Dr. David Alan Gilbert >=20 > Reviewed-by: Amit Shah >=20 >> v19: >> - fix colo_supported() to return true >> v11: >> - Turn COLO on in default (Eric's suggestion) >=20 > Can you recap why the suggestion was made to switch it on by default? If the feature doesn't depend on external libraries, then enabling compilation by default will avoid bitrot. But mentioning this rationale in the commit message never hurts :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MJ5NVfLdctq1GFhk8xfeUVVEgvKSqNLrQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYELLDAAoJEKeha0olJ0NqaUEH/RXvR7hWsh+qQJcGfX+jtbHZ du/a5O4tQ/V+SBSH0HOUAyUdE9WgQ9g4N6i32K0Rb1fJKJkVAbh1zZjnMnizWkf5 wTwgEpf1dtZDGvGxkYZ+6/DNP0gk/RfsYO47VO9vnzI8tI4W/wuwJBNPUezTryNm 8s8hYGwRDvO4kK7g5fctrgSA2woO3uOlOhIBSYr3eWjFXp24tRsv0O39OzfO3cSM amB3Pu7OeNJ/vhJiGT3viWUIYlWyu6RS0UsyaIUgOMeKhua5U6p4WePmj6C+yztL uk4eulKmHX7PCv6g4Zd+VfXGLfHPkiWdU9TRY+/72v9s1XuMCSjTT68UElb3uAM= =S9lG -----END PGP SIGNATURE----- --MJ5NVfLdctq1GFhk8xfeUVVEgvKSqNLrQ--