From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers
Date: Sat, 19 Jun 2021 05:41:37 -0700 [thread overview]
Message-ID: <79cfc24f-d271-fbf6-33bc-b8c2f1381b5a@linaro.org> (raw)
In-Reply-To: <ea1ec188-d011-e8f2-7131-3946bfd6d963@amsat.org>
On 6/19/21 2:26 AM, Philippe Mathieu-Daudé wrote:
>> It doesn't seem to match the next
>> two patches, which don't create new compilation units.
>
> Indeed. In a yet-to-be-posted later series they get renamed to .c,
> becoming new units.
Ah, ok.
> What I can do is hold these patches and post them later with the
> yet-to-be-posted series, *but* that breaks the "extract nanomips
> from translate.c" which you already reviewed :/
I don't mind the ordering, just that there's a reason.
> It is hard to split this huge 25k+ spaghetti translate.c :(
I can well imagine.
r~
next prev parent reply other threads:[~2021-06-19 12:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 17:49 [PATCH 0/4] target/mips: Extract microMIPS ISA and Code Compaction ASE apart Philippe Mathieu-Daudé
2021-06-17 17:49 ` [PATCH 1/4] target/mips: Add declarations for generic TCG helpers Philippe Mathieu-Daudé
2021-06-18 20:15 ` Richard Henderson
2021-06-19 9:26 ` Philippe Mathieu-Daudé
2021-06-19 12:41 ` Richard Henderson [this message]
2021-06-28 16:33 ` Philippe Mathieu-Daudé
2021-06-28 21:31 ` Richard Henderson
2021-06-17 17:49 ` [PATCH 2/4] target/mips: Extract Code Compaction ASE translation routines Philippe Mathieu-Daudé
2021-06-17 17:49 ` [PATCH 3/4] target/mips: Extract the microMIPS ISA " Philippe Mathieu-Daudé
2021-06-17 17:49 ` [PATCH 4/4] target/mips: Add declarations for generic DSP TCG helpers Philippe Mathieu-Daudé
2021-06-17 18:25 ` Philippe Mathieu-Daudé
2021-06-18 20:17 ` Richard Henderson
2021-06-29 4:35 ` [PATCH 0/4] target/mips: Extract microMIPS ISA and Code Compaction ASE apart Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79cfc24f-d271-fbf6-33bc-b8c2f1381b5a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).