* [PATCH] target/ppc/kvm : Use macro names instead of hardcoded constants as return values
@ 2025-12-02 12:46 Gautam Menghani
2025-12-04 9:52 ` Chinmay Rath
2025-12-04 17:10 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Gautam Menghani @ 2025-12-02 12:46 UTC (permalink / raw)
To: npiggin, harshpb, rathc, pbonzini, sjitindarsingh
Cc: Gautam Menghani, qemu-ppc, kvm, qemu-devel
In the parse_* functions used to parse the return values of
KVM_PPC_GET_CPU_CHAR ioctl, the return values are hardcoded as numbers.
Use the macro names for better readability. No functional change
intended.
Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
---
target/ppc/kvm.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index 43124bf1c7..464240d911 100644
--- a/target/ppc/kvm.c
+++ b/target/ppc/kvm.c
@@ -2450,26 +2450,26 @@ static int parse_cap_ppc_safe_cache(struct kvm_ppc_cpu_char c)
bool l1d_thread_priv_req = !kvmppc_power8_host();
if (~c.behaviour & c.behaviour_mask & H_CPU_BEHAV_L1D_FLUSH_PR) {
- return 2;
+ return SPAPR_CAP_FIXED;
} else if ((!l1d_thread_priv_req ||
c.character & c.character_mask & H_CPU_CHAR_L1D_THREAD_PRIV) &&
(c.character & c.character_mask
& (H_CPU_CHAR_L1D_FLUSH_ORI30 | H_CPU_CHAR_L1D_FLUSH_TRIG2))) {
- return 1;
+ return SPAPR_CAP_WORKAROUND;
}
- return 0;
+ return SPAPR_CAP_BROKEN;
}
static int parse_cap_ppc_safe_bounds_check(struct kvm_ppc_cpu_char c)
{
if (~c.behaviour & c.behaviour_mask & H_CPU_BEHAV_BNDS_CHK_SPEC_BAR) {
- return 2;
+ return SPAPR_CAP_FIXED;
} else if (c.character & c.character_mask & H_CPU_CHAR_SPEC_BAR_ORI31) {
- return 1;
+ return SPAPR_CAP_WORKAROUND;
}
- return 0;
+ return SPAPR_CAP_BROKEN;
}
static int parse_cap_ppc_safe_indirect_branch(struct kvm_ppc_cpu_char c)
@@ -2486,15 +2486,15 @@ static int parse_cap_ppc_safe_indirect_branch(struct kvm_ppc_cpu_char c)
return SPAPR_CAP_FIXED_IBS;
}
- return 0;
+ return SPAPR_CAP_BROKEN;
}
static int parse_cap_ppc_count_cache_flush_assist(struct kvm_ppc_cpu_char c)
{
if (c.character & c.character_mask & H_CPU_CHAR_BCCTR_FLUSH_ASSIST) {
- return 1;
+ return SPAPR_CAP_WORKAROUND;
}
- return 0;
+ return SPAPR_CAP_BROKEN;
}
bool kvmppc_has_cap_xive(void)
--
2.51.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/ppc/kvm : Use macro names instead of hardcoded constants as return values
2025-12-02 12:46 [PATCH] target/ppc/kvm : Use macro names instead of hardcoded constants as return values Gautam Menghani
@ 2025-12-04 9:52 ` Chinmay Rath
2025-12-04 17:10 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Chinmay Rath @ 2025-12-04 9:52 UTC (permalink / raw)
To: Gautam Menghani, npiggin, harshpb, pbonzini, sjitindarsingh
Cc: qemu-ppc, kvm, qemu-devel
On 12/2/25 18:16, Gautam Menghani wrote:
> In the parse_* functions used to parse the return values of
> KVM_PPC_GET_CPU_CHAR ioctl, the return values are hardcoded as numbers.
> Use the macro names for better readability. No functional change
> intended.
>
> Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
> ---
Reviewed-by: Chinmay Rath <rathc@linux.ibm.com>
> target/ppc/kvm.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index 43124bf1c7..464240d911 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -2450,26 +2450,26 @@ static int parse_cap_ppc_safe_cache(struct kvm_ppc_cpu_char c)
> bool l1d_thread_priv_req = !kvmppc_power8_host();
>
> if (~c.behaviour & c.behaviour_mask & H_CPU_BEHAV_L1D_FLUSH_PR) {
> - return 2;
> + return SPAPR_CAP_FIXED;
> } else if ((!l1d_thread_priv_req ||
> c.character & c.character_mask & H_CPU_CHAR_L1D_THREAD_PRIV) &&
> (c.character & c.character_mask
> & (H_CPU_CHAR_L1D_FLUSH_ORI30 | H_CPU_CHAR_L1D_FLUSH_TRIG2))) {
> - return 1;
> + return SPAPR_CAP_WORKAROUND;
> }
>
> - return 0;
> + return SPAPR_CAP_BROKEN;
> }
>
> static int parse_cap_ppc_safe_bounds_check(struct kvm_ppc_cpu_char c)
> {
> if (~c.behaviour & c.behaviour_mask & H_CPU_BEHAV_BNDS_CHK_SPEC_BAR) {
> - return 2;
> + return SPAPR_CAP_FIXED;
> } else if (c.character & c.character_mask & H_CPU_CHAR_SPEC_BAR_ORI31) {
> - return 1;
> + return SPAPR_CAP_WORKAROUND;
> }
>
> - return 0;
> + return SPAPR_CAP_BROKEN;
> }
>
> static int parse_cap_ppc_safe_indirect_branch(struct kvm_ppc_cpu_char c)
> @@ -2486,15 +2486,15 @@ static int parse_cap_ppc_safe_indirect_branch(struct kvm_ppc_cpu_char c)
> return SPAPR_CAP_FIXED_IBS;
> }
>
> - return 0;
> + return SPAPR_CAP_BROKEN;
> }
>
> static int parse_cap_ppc_count_cache_flush_assist(struct kvm_ppc_cpu_char c)
> {
> if (c.character & c.character_mask & H_CPU_CHAR_BCCTR_FLUSH_ASSIST) {
> - return 1;
> + return SPAPR_CAP_WORKAROUND;
> }
> - return 0;
> + return SPAPR_CAP_BROKEN;
> }
>
> bool kvmppc_has_cap_xive(void)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] target/ppc/kvm : Use macro names instead of hardcoded constants as return values
2025-12-02 12:46 [PATCH] target/ppc/kvm : Use macro names instead of hardcoded constants as return values Gautam Menghani
2025-12-04 9:52 ` Chinmay Rath
@ 2025-12-04 17:10 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-12-04 17:10 UTC (permalink / raw)
To: Gautam Menghani, npiggin, harshpb, rathc, pbonzini,
sjitindarsingh
Cc: qemu-ppc, kvm, qemu-devel
On 2/12/25 13:46, Gautam Menghani wrote:
> In the parse_* functions used to parse the return values of
> KVM_PPC_GET_CPU_CHAR ioctl, the return values are hardcoded as numbers.
> Use the macro names for better readability. No functional change
> intended.
>
> Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
> ---
> target/ppc/kvm.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Nice cleanup, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-04 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-02 12:46 [PATCH] target/ppc/kvm : Use macro names instead of hardcoded constants as return values Gautam Menghani
2025-12-04 9:52 ` Chinmay Rath
2025-12-04 17:10 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).