From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888B3C432C0 for ; Fri, 22 Nov 2019 12:32:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C3E520714 for ; Fri, 22 Nov 2019 12:32:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C3E520714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iY86t-00040K-Fa for qemu-devel@archiver.kernel.org; Fri, 22 Nov 2019 07:32:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47095) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iY85U-00030b-6m for qemu-devel@nongnu.org; Fri, 22 Nov 2019 07:31:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iY85T-0002Qp-0e for qemu-devel@nongnu.org; Fri, 22 Nov 2019 07:31:00 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:8480 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iY85S-0002Qj-Qh for qemu-devel@nongnu.org; Fri, 22 Nov 2019 07:30:58 -0500 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAMCSXOv021510 for ; Fri, 22 Nov 2019 07:30:58 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wdkdfr09s-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 22 Nov 2019 07:30:58 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 Nov 2019 12:30:56 -0000 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 22 Nov 2019 12:30:53 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xAMCUD1i34865584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 22 Nov 2019 12:30:13 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9CB2911C052; Fri, 22 Nov 2019 12:30:51 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2923211C04A; Fri, 22 Nov 2019 12:30:51 +0000 (GMT) Received: from localhost.localdomain (unknown [9.145.41.23]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 22 Nov 2019 12:30:51 +0000 (GMT) Subject: Re: [PATCH 4/4] s390x: Beautify machine reset To: David Hildenbrand , Cornelia Huck References: <20191122075218.23935-1-frankja@linux.ibm.com> <20191122075218.23935-5-frankja@linux.ibm.com> <20191122131035.4f334a99.cohuck@redhat.com> <8217f5a5-1700-9371-d642-8520df9df0ed@linux.ibm.com> <925e1c0e-bf63-a244-df72-2f477d014666@redhat.com> From: Janosch Frank Autocrypt: addr=frankja@linux.ibm.com; prefer-encrypt=mutual; keydata= mQINBFubpD4BEADX0uhkRhkj2AVn7kI4IuPY3A8xKat0ihuPDXbynUC77mNox7yvK3X5QBO6 qLqYr+qrG3buymJJRD9xkp4mqgasHdB5WR9MhXWKH08EvtvAMkEJLnqxgbqf8td3pCQ2cEpv 15mH49iKSmlTcJ+PvJpGZcq/jE42u9/0YFHhozm8GfQdb9SOI/wBSsOqcXcLTUeAvbdqSBZe zuMRBivJQQI1esD9HuADmxdE7c4AeMlap9MvxvUtWk4ZJ/1Z3swMVCGzZb2Xg/9jZpLsyQzb lDbbTlEeyBACeED7DYLZI3d0SFKeJZ1SUyMmSOcr9zeSh4S4h4w8xgDDGmeDVygBQZa1HaoL Esb8Y4avOYIgYDhgkCh0nol7XQ5i/yKLtnNThubAcxNyryw1xSstnKlxPRoxtqTsxMAiSekk 0m3WJwvwd1s878HrQNK0orWd8BzzlSswzjNfQYLF466JOjHPWFOok9pzRs+ucrs6MUwDJj0S cITWU9Rxb04XyigY4XmZ8dywaxwi2ZVTEg+MD+sPmRrTw+5F+sU83cUstuymF3w1GmyofgsU Z+/ldjToHnq21MNa1wx0lCEipCCyE/8K9B9bg9pUwy5lfx7yORP3JuAUfCYb8DVSHWBPHKNj HTOLb2g2UT65AjZEQE95U2AY9iYm5usMqaWD39pAHfhC09/7NQARAQABtCVKYW5vc2NoIEZy YW5rIDxmcmFua2phQGxpbnV4LmlibS5jb20+iQI3BBMBCAAhBQJbm6Q+AhsjBQsJCAcCBhUI CQoLAgQWAgMBAh4BAheAAAoJEONU5rjiOLn4p9gQALjkdj5euJVI2nNT3/IAxAhQSmRhPEt0 AmnCYnuTcHRWPujNr5kqgtyER9+EMQ0ZkX44JU2q7OWxTdSNSAN/5Z7qmOR9JySvDOf4d3mS bMB5zxL9d8SbnSs1uW96H9ZBTlTQnmLfsiM9TetAjSrR8nUmjGhe2YUhJLR1v1LguME+YseT eXnLzIzqqpu311/eYiiIGcmaOjPCE+vFjcXL5oLnGUE73qSYiujwhfPCCUK0850o1fUAYq5p CNBCoKT4OddZR+0itKc/cT6NwEDwdokeg0+rAhxb4Rv5oFO70lziBplEjOxu3dqgIKbHbjza EXTb+mr7VI9O4tTdqrwJo2q9zLqqOfDBi7NDvZFLzaCewhbdEpDYVu6/WxprAY94hY3F4trT rQMHJKQENtF6ZTQc9fcT5I3gAmP+OEvDE5hcTALpWm6Z6SzxO7gEYCnF+qGXqp8sJVrweMub UscyLqHoqdZC2UG4LQ1OJ97nzDpIRe0g6oJ9ZIYHKmfw5jjwH6rASTld5MFWajWdNsqK15k/ RZnHAGICKVIBOBsq26m4EsBlfCdt3b/6emuBjUXR1pyjHMz2awWzCq6/6OWs5eANZ0sdosNq dq2v0ULYTazJz2rlCXV89qRa7ukkNwdBSZNEwsD4eEMicj1LSrqWDZMAALw50L4jxaMD7lPL jJbauQINBFubpD4BEADAcUTRqXF/aY53OSH7IwIK9lFKxIm0IoFkOEh7LMfp7FGzaP7ANrZd cIzhZi38xyOkcaFY+npGEWvko7rlIAn0JpBO4x3hfhmhBD/WSY8LQIFQNNjEm3vzrMo7b9Jb JAqQxfbURY3Dql3GUzeWTG9uaJ00u+EEPlY8zcVShDltIl5PLih20e8xgTnNzx5c110lQSu0 iZv2lAE6DM+2bJQTsMSYiwKlwTuv9LI9Chnoo6+tsN55NqyMxYqJgElk3VzlTXSr3+rtSCwf tq2cinETbzxc1XuhIX6pu/aCGnNfuEkM34b7G1D6CPzDMqokNFbyoO6DQ1+fW6c5gctXg/lZ 602iEl4C4rgcr3+EpfoPUWzKeM8JXv5Kpq4YDxhvbitr8Dm8gr38+UKFZKlWLlwhQ56r/zAU v6LIsm11GmFs2/cmgD1bqBTNHHcTWwWtRTLgmnqJbVisMJuYJt4KNPqphTWsPY8SEtbufIlY HXOJ2lqUzOReTrie2u0qcSvGAbSfec9apTFl2Xko/ddqPcZMpKhBiXmY8tJzSPk3+G4tqur4 6TYAm5ouitJsgAR61Cu7s+PNuq/pTLDhK+6/Njmc94NGBcRA4qTuysEGE79vYWP2oIAU4Fv6 gqaWHZ4MEI2XTqH8wiwzPdCQPYsSE0fXWiYu7ObeErT6iLSTZGx4rQARAQABiQIfBBgBCAAJ BQJbm6Q+AhsMAAoJEONU5rjiOLn4DDEP/RuyckW65SZcPG4cMfNgWxZF8rVjeVl/9PBfy01K 8R0hajU40bWtXSMiby7j0/dMjz99jN6L+AJHJvrLz4qYRzn2Ys843W+RfXj62Zde4YNBE5SL jJweRCbMWKaJLj6499fctxTyeb9+AMLQS4yRSwHuAZLmAb5AyCW1gBcTWZb8ON5BmWnRqeGm IgC1EvCnHy++aBnHTn0m+zV89BhTLTUal35tcjUFwluBY39R2ux/HNlBO1GY3Z+WYXhBvq7q katThLjaQSmnOrMhzqYmdShP1leFTVbzXUUIYv/GbynO/YrL2gaQpaP1bEUEi8lUAfXJbEWG dnHFkciryi092E8/9j89DJg4mmZqOau7TtUxjRMlBcIliXkzSLUk+QvD4LK1kWievJse4mte FBdkWHfP4BH/+8DxapRcG1UAheSnSRQ5LiO50annOB7oXF+vgKIaie2TBfZxQNGAs3RQ+bga DchCqFm5adiSP5+OT4NjkKUeGpBe/aRyQSle/RropTgCi85pje/juYEn2P9UAgkfBJrOHvQ9 Z+2Sva8FRd61NJLkCJ4LFumRn9wQlX2icFbi8UDV3do0hXJRRYTWCxrHscMhkrFWLhYiPF4i phX7UNdOWBQ90qpHyAxHmDazdo27gEjfvsgYMdveKknEOTEb5phwxWgg7BcIDoJf9UMC Date: Fri, 22 Nov 2019 13:30:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <925e1c0e-bf63-a244-df72-2f477d014666@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0OYiY1mI57uylnCuWnwVfgvYt1M08aIJv" X-TM-AS-GCONF: 00 x-cbid: 19112212-0008-0000-0000-000003362099 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19112212-0009-0000-0000-00004A554E19 Message-Id: <79f5a114-7991-51c7-9e8e-609c2bb78818@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-22_02:2019-11-21,2019-11-22 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 adultscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 impostorscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911220112 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, pmorel@linux.ibm.com, qemu-devel@nongnu.org, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, mihajlov@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0OYiY1mI57uylnCuWnwVfgvYt1M08aIJv Content-Type: multipart/mixed; boundary="Yhs2o6c0Xan5kbw7wHSIEaZInTxmf5KW7" --Yhs2o6c0Xan5kbw7wHSIEaZInTxmf5KW7 Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/22/19 1:25 PM, David Hildenbrand wrote: > On 22.11.19 13:22, Janosch Frank wrote: >> On 11/22/19 1:10 PM, Cornelia Huck wrote: >>> On Fri, 22 Nov 2019 12:47:44 +0100 >>> David Hildenbrand wrote: >>> >>>> On 22.11.19 12:46, Janosch Frank wrote: >>>>> On 11/22/19 11:59 AM, David Hildenbrand wrote: >>>>>> On 22.11.19 08:52, Janosch Frank wrote: >>>>>>> * Add comments that tell you which diag308 subcode caused the res= et >>>>>>> * Sort by diag308 reset subcode >>>>>>> >>>>>>> Signed-off-by: Janosch Frank >>>>>>> --- >>>>>>> hw/s390x/s390-virtio-ccw.c | 20 ++++++++++---------- >>>>>>> 1 file changed, 10 insertions(+), 10 deletions(-) >>>>>>> >>>>>>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-cc= w.c >>>>>>> index c1d1440272..88f7758721 100644 >>>>>>> --- a/hw/s390x/s390-virtio-ccw.c >>>>>>> +++ b/hw/s390x/s390-virtio-ccw.c >>>>>>> @@ -330,15 +330,7 @@ static void s390_machine_reset(MachineState = *machine) >>>>>>> s390_cmma_reset(); >>>>>>> =20 >>>>>>> switch (reset_type) { >>>>>>> - case S390_RESET_EXTERNAL: >>>>>>> - case S390_RESET_REIPL: >>>>>>> - qemu_devices_reset(); >>>>>>> - s390_crypto_reset(); >>>>>>> - >>>>>>> - /* configure and start the ipl CPU only */ >>>>>>> - run_on_cpu(cs, s390_do_cpu_ipl, RUN_ON_CPU_NULL); >>>>>>> - break; >>>>>>> - case S390_RESET_MODIFIED_CLEAR: >>>>>>> + case S390_RESET_MODIFIED_CLEAR: /* Subcode 0 */ >>>>>> >>>>>> IMHO "Subcode X" isn't of much help here. We're out of diag handli= ng. >>>>>> >>>>>> I'd suggest to just document the subcodes along with the definitio= ns, if >>>>>> really needed, and drop this patch, at least I don't quite see the= value >>>>>> of moving code around here... or is the code shuffling of any valu= e on >>>>>> your prot virt patches? >>>>>> =20 >>>>> >>>>> It keeps me from consulting the POP every time I need to change thi= ngs >>>>> in the machine resets. This is basically a 1:1 mapping of diag 308 >>>>> subcodes to machine resets, so why don't we want to make that obvio= us >>>>> and order them by the subcodes? >>>>> =20 >>>> >>>> Because it is not a 1:1 mapping: S390_RESET_EXTERNAL >>>> >>> >>> Tack the explanation onto the definitions of S390_RESET_, then? >>> Probably still quicker than consulting the POP :) >>> >> >> Does it really bother you that much, that I add some explanations to t= he >> things we're doing. The external reset also gets a comment so Conni >> won't need that much coffee anymore to understand the code :-) >> >=20 > I'm really sorry, but I fail to see how "Subcode 0" is *any* better tha= n=20 > S390_RESET_MODIFIED_CLEAR (and avoids consulting the PoP) and why the=20 > order should matter at all here to make it easier to understand. >=20 > I don't NACK this, I just find it *completely* useless :) >=20 Ugh, time for some rebase conflicts... --Yhs2o6c0Xan5kbw7wHSIEaZInTxmf5KW7-- --0OYiY1mI57uylnCuWnwVfgvYt1M08aIJv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEwGNS88vfc9+v45Yq41TmuOI4ufgFAl3X1PoACgkQ41TmuOI4 ufgnRg/7B92ZPW1cZYwdeoMSeNDssYGfXgHTqeBEcAn783FF8roOB2D2MgD1+j7H PzBVpDIjuXi2uG3fGEfpvbFtCMfLuwlaFK8zX7/g3YT3HZolOghN7Z7qjJk+MQz4 s6+LLPfqzsVZwKEw5iJ3aRBeMZ5RPM3jcjenhKa1smPulEhGOftfeyid4MaNHS88 tFUEIoKPekLJMEr1POtB7B+b9qw1qyeb4TxFri0zh6nI7XWuz6+zp2bsb86Wdywm WUiYZ7E2+oJAuRTRahNk9Ko7BCwgfduN6kJbJCpQueQ0Ea15ySlKkKwtU/Ufwviq i+zITDlCsTsYQ5pNHOx8KJUnPJYSphY2jIxOkgY4PHgS8aGD7YS3mGqFtR8UqMCV lW8QQFNC7HK8nZ5p3l70HhdIb5XMvq548V5yeFiNpEU6YcLY5fB1XCi5f04gJpKF oexiD0T8vQH/bWAxRm9oCJGeBkkiLVZ/VQZG6ZQ2nmmj/m8fXFpGO2RzfIj8tAyB vE+Hf46YCTlnhut6y708LpwqcARFgGHgjoFUMh+YyQdKhi4y+p5qkK1zrIfXQlaA v1mw4ZB4YjwkFnNIvmETBi2E8GtJILR9CpFBmohNgXTiWYqWLvA4zGraJWYOEyic C/Ug1Nf3KbCZghWk0v9k2RUzzJzYZZ+wMrI5RFnfCdCaXR9EASQ= =27QO -----END PGP SIGNATURE----- --0OYiY1mI57uylnCuWnwVfgvYt1M08aIJv--