* [PATCH] qapi: document PCIe Gen5/Gen6 speeds since 9.0
@ 2024-03-13 6:50 Michael S. Tsirkin
2024-03-13 10:14 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2024-03-13 6:50 UTC (permalink / raw)
To: qemu-devel
Cc: Lukas Stockner, Marcel Apfelbaum, Markus Armbruster, Eric Blake
Document that PCIe Gen5/Gen6 speeds are only in QAPI
since 9.0 - the rest is since 4.0.
Cc: Lukas Stockner <lstockner@genesiscloud.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds")
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
qapi/common.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/common.json b/qapi/common.json
index 867a9ad9b0..7558ce5430 100644
--- a/qapi/common.json
+++ b/qapi/common.json
@@ -107,9 +107,9 @@
#
# @16: 16.0GT/s
#
-# @32: 32.0GT/s
+# @32: 32.0GT/s (since 9.0)
#
-# @64: 64.0GT/s
+# @64: 64.0GT/s (since 9.0)
#
# Since: 4.0
##
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] qapi: document PCIe Gen5/Gen6 speeds since 9.0
2024-03-13 6:50 [PATCH] qapi: document PCIe Gen5/Gen6 speeds since 9.0 Michael S. Tsirkin
@ 2024-03-13 10:14 ` Philippe Mathieu-Daudé
2024-03-13 10:22 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-13 10:14 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Lukas Stockner, Marcel Apfelbaum, Markus Armbruster, Eric Blake
On 13/3/24 07:50, Michael S. Tsirkin wrote:
> Document that PCIe Gen5/Gen6 speeds are only in QAPI
> since 9.0 - the rest is since 4.0.
>
> Cc: Lukas Stockner <lstockner@genesiscloud.com>
> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds")
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> qapi/common.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] qapi: document PCIe Gen5/Gen6 speeds since 9.0
2024-03-13 10:14 ` Philippe Mathieu-Daudé
@ 2024-03-13 10:22 ` Philippe Mathieu-Daudé
2024-03-13 10:24 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-13 10:22 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Lukas Stockner, Marcel Apfelbaum, Markus Armbruster, Eric Blake
On 13/3/24 11:14, Philippe Mathieu-Daudé wrote:
> On 13/3/24 07:50, Michael S. Tsirkin wrote:
>> Document that PCIe Gen5/Gen6 speeds are only in QAPI
>> since 9.0 - the rest is since 4.0.
>>
>> Cc: Lukas Stockner <lstockner@genesiscloud.com>
>> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
>> Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds")
(BTW if you have to repost your pullreq as v2, you could
squash this change).
>> Suggested-by: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>> qapi/common.json | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] qapi: document PCIe Gen5/Gen6 speeds since 9.0
2024-03-13 10:22 ` Philippe Mathieu-Daudé
@ 2024-03-13 10:24 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2024-03-13 10:24 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Lukas Stockner, Marcel Apfelbaum, Markus Armbruster,
Eric Blake
On Wed, Mar 13, 2024 at 11:22:43AM +0100, Philippe Mathieu-Daudé wrote:
> On 13/3/24 11:14, Philippe Mathieu-Daudé wrote:
> > On 13/3/24 07:50, Michael S. Tsirkin wrote:
> > > Document that PCIe Gen5/Gen6 speeds are only in QAPI
> > > since 9.0 - the rest is since 4.0.
> > >
> > > Cc: Lukas Stockner <lstockner@genesiscloud.com>
> > > Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> > > Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds")
>
> (BTW if you have to repost your pullreq as v2, you could
> squash this change).
Does not break bisect in any way, it's a comment so I do
not see a reason to squash.
> > > Suggested-by: Markus Armbruster <armbru@redhat.com>
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> > > qapi/common.json | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-13 10:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-13 6:50 [PATCH] qapi: document PCIe Gen5/Gen6 speeds since 9.0 Michael S. Tsirkin
2024-03-13 10:14 ` Philippe Mathieu-Daudé
2024-03-13 10:22 ` Philippe Mathieu-Daudé
2024-03-13 10:24 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).