Re: [Qemu-devel] [PATCH v2 1/6] block/dirty-bitmap: add recording and busy properties

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

On 2/13/19 5:23 PM, John Snow wrote:
> The current API allows us to report a single status, which we've defined as:
> 
> Frozen: has a successor, treated as qmp_locked, may or may not be enabled.
> Locked: no successor, qmp_locked. may or may not be enabled.
> Disabled: Not frozen or locked, disabled.
> Active: Not frozen, locked, or disabled.
> 
> The problem is that both "Frozen" and "Locked" mean nearly the same thing,
> and that both of them do not intuit whether they are recording guest writes
> or not.
> 
> This patch deprecates that status field and introduces two orthogonal
> properties instead to replace it.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  block/dirty-bitmap.c       |  9 +++++++++
>  qapi/block-core.json       | 10 +++++++++-
>  qemu-deprecated.texi       |  6 ++++++
>  tests/qemu-iotests/236.out | 28 ++++++++++++++++++++++++++++
>  4 files changed, 52 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]