From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, den@openvz.org,
qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v5 0/9] qcow2-bitmaps: rewrite reopening logic
Date: Fri, 27 Sep 2019 18:41:21 -0400 [thread overview]
Message-ID: <7a403dbc-f93a-6d2f-814a-5025905a7a5f@redhat.com> (raw)
In-Reply-To: <20190927122355.7344-1-vsementsov@virtuozzo.com>
On 9/27/19 8:23 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> Bitmaps reopening is buggy, reopening-rw just not working at all and
> reopening-ro may lead to producing broken incremental
> backup if we do temporary snapshot in a meantime.
>
> v5:
> 01: - add Max's r-b
> - fix s/QSIMPLE_INIT/QTAILQ_INIT/ in a comment
> 02: - add Max's and John's a-b
> 03: - improve test to check bitmap hashes in more safe way
> 07: - drop wrong statement from commit message
> - log events by hand
> 08: - drop 'the' from comment
> - add Corruption in case of existent IN_USE on RO->RW reopen
> 09: - add Max's a-b and John's r-b
>
> v4: Drop complicated solution around reopening logic [Kevin], fix
> the existing bug in a simplest way
>
> Vladimir Sementsov-Ogievskiy (9):
> block: switch reopen queue from QSIMPLEQ to QTAILQ
> block: reverse order for reopen commits
> iotests: add test-case to 165 to test reopening qcow2 bitmaps to RW
> block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps
> block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint()
> block/qcow2-bitmap: do not remove bitmaps on reopen-ro
> iotests: add test 260 to check bitmap life after snapshot + commit
> block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw
> qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_commit
>
> block/qcow2.h | 5 +-
> include/block/block.h | 2 +-
> include/block/block_int.h | 6 --
> include/block/dirty-bitmap.h | 1 -
> block.c | 53 +++++------
> block/dirty-bitmap.c | 12 ---
> block/qcow2-bitmap.c | 164 ++++++++++++++++++++++-------------
> block/qcow2.c | 17 +++-
> tests/qemu-iotests/165 | 57 +++++++++++-
> tests/qemu-iotests/165.out | 4 +-
> tests/qemu-iotests/260 | 89 +++++++++++++++++++
> tests/qemu-iotests/260.out | 52 +++++++++++
> tests/qemu-iotests/group | 1 +
> 13 files changed, 343 insertions(+), 120 deletions(-)
> create mode 100755 tests/qemu-iotests/260
> create mode 100644 tests/qemu-iotests/260.out
>
With the understanding that there are caveats that make this unsafe, but
less unsafe and is a strict improvement:
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2019-09-27 22:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 12:23 [PATCH v5 0/9] qcow2-bitmaps: rewrite reopening logic Vladimir Sementsov-Ogievskiy
2019-09-27 12:23 ` [PATCH v5 1/9] block: switch reopen queue from QSIMPLEQ to QTAILQ Vladimir Sementsov-Ogievskiy
2019-09-27 12:23 ` [PATCH v5 2/9] block: reverse order for reopen commits Vladimir Sementsov-Ogievskiy
2019-09-27 12:23 ` [PATCH v5 3/9] iotests: add test-case to 165 to test reopening qcow2 bitmaps to RW Vladimir Sementsov-Ogievskiy
2019-09-27 20:43 ` John Snow
2019-09-27 12:23 ` [PATCH v5 4/9] block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps Vladimir Sementsov-Ogievskiy
2019-09-27 12:23 ` [PATCH v5 5/9] block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint() Vladimir Sementsov-Ogievskiy
2019-09-27 12:23 ` [PATCH v5 6/9] block/qcow2-bitmap: do not remove bitmaps on reopen-ro Vladimir Sementsov-Ogievskiy
2019-09-27 12:23 ` [PATCH v5 7/9] iotests: add test 260 to check bitmap life after snapshot + commit Vladimir Sementsov-Ogievskiy
2019-09-27 12:23 ` [PATCH v5 8/9] block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw Vladimir Sementsov-Ogievskiy
2019-09-27 12:23 ` [PATCH v5 9/9] qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_commit Vladimir Sementsov-Ogievskiy
2019-09-27 22:41 ` John Snow [this message]
2019-09-27 23:36 ` [PATCH v5 0/9] qcow2-bitmaps: rewrite reopening logic John Snow
2019-09-30 10:32 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a403dbc-f93a-6d2f-814a-5025905a7a5f@redhat.com \
--to=jsnow@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).