From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Fiona Ebner <f.ebner@proxmox.com>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, lvivier@redhat.com, pbonzini@redhat.com,
srowe@mose.org.uk, mike.maslenkin@gmail.com,
qemu-block@nongnu.org, t.lamprecht@proxmox.com,
a.lauterer@proxmox.com
Subject: Re: [POC 2/2] add test exposing AHCI reset issue
Date: Thu, 24 Aug 2023 17:09:46 +0200 [thread overview]
Message-ID: <7a42f1f9-c492-f6ff-fd4d-2c84052835de@linaro.org> (raw)
In-Reply-To: <20230824133831.617833-2-f.ebner@proxmox.com>
On 24/8/23 15:38, Fiona Ebner wrote:
> Fails without the previous commit "hw/ide: reset: cancel async DMA
> operation before reseting state".
>
> I haven't ever written such a test before, but I wanted something to
> expose the problem more easily. It hardcodes the behavior that the
> pending write actually is done during reset, which might not be ideal.
> It could just check that the first sector is still intact instead.
>
> If I should make this a proper test, I'd be happy about some guidance,
> but not sure if required for such a specific one-off issue. After all,
> a different variation of the bug might have written to some other
> sector not covered by this test.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> tests/qtest/ahci-test.c | 81 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 81 insertions(+)
Per our style, variables are allocated on function prologue,
otherwise the test LGTM:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-08-24 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 13:38 [PATCH 1/2] hw/ide: reset: cancel async DMA operation before reseting state Fiona Ebner
2023-08-24 13:38 ` [POC 2/2] add test exposing AHCI reset issue Fiona Ebner
2023-08-24 15:09 ` Philippe Mathieu-Daudé [this message]
2023-08-24 15:52 ` Thomas Huth
2023-08-25 10:17 ` Fiona Ebner
2023-09-04 9:26 ` Kevin Wolf
2023-08-24 15:07 ` [PATCH 1/2] hw/ide: reset: cancel async DMA operation before reseting state Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a42f1f9-c492-f6ff-fd4d-2c84052835de@linaro.org \
--to=philmd@linaro.org \
--cc=a.lauterer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=lvivier@redhat.com \
--cc=mike.maslenkin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=srowe@mose.org.uk \
--cc=t.lamprecht@proxmox.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).