Re: [Qemu-devel] [PATCH v3] docs/devel/loads-stores.rst: Document our various load and store APIs

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]

On 10/10/2017 12:14 PM, Peter Maydell wrote:
> QEMU has a wide selection of different functions for doing
> loads and stores; provide some overview documentation of
> what they do and how to pick which one to use.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Changes v2->v3: fixed the typos noticed by Eric;

well, most of them. :)

> dropped the note about license in favour of using the
> default gpl2+. I think this is ready to commit now.

With the remaining nits fixed,

Reviewed-by: Eric Blake <eblake@redhat.com>

> +``ld*_p and st*_p``
> +~~~~~~~~~~~~~~~~~~~

> +``endian``
> + - ``he`` : host endian
> + - ``be`` : big endian
> + - ``le`` : little endian
> +
> +(except for byte accesses, which have no endian infix).
> +
> +The ``_{endian}`` infix is omitted for target-endian accesses.
> +

Is the parenthetical paragraph necessary, given the next paragraph, and
given that you have a similar statement later on for ``{ld,st}*_phys``
without needing the parenthetical?

> +
> +``cpu_{ld,st}_*_ra``
> +~~~~~~~~~~~~~~~~~~~~
> +
> +Thes functions work like the ``cpu_{ld,st}_*`` functions except

s/Thes/These/

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]