qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH] target/m68k: Remove unused @cpu_exception_index TCGv
Date: Wed, 24 Sep 2025 10:24:42 -0700	[thread overview]
Message-ID: <7a4fe7cc-9627-4a62-a51b-9435719ba21c@linaro.org> (raw)
In-Reply-To: <20250924171308.53036-1-philmd@linaro.org>

On 9/24/25 10:13, Philippe Mathieu-Daudé wrote:
> When moving the @exception_index from each target ArchCPU
> to the global CPUState in commit 27103424c40 ("cpu: Move
> exception_index field from CPU_COMMON to CPUState"), the
> @cpu_exception_index TCGv has been created for m68k target.
> 
> For years, no code ever used this register. Simply remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/m68k/translate.c | 6 ------
>   1 file changed, 6 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

> 
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index 97afceb1297..0cee54f4900 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -45,7 +45,6 @@
>   #undef DEFO64
>   
>   static TCGv_i32 cpu_halted;
> -static TCGv_i32 cpu_exception_index;
>   
>   static char cpu_reg_names[2 * 8 * 3 + 5 * 4];
>   static TCGv cpu_dregs[8];
> @@ -81,11 +80,6 @@ void m68k_tcg_init(void)
>       cpu_halted = tcg_global_mem_new_i32(tcg_env,
>                                           -offsetof(M68kCPU, env) +
>                                           offsetof(CPUState, halted), "HALTED");
> -    cpu_exception_index = tcg_global_mem_new_i32(tcg_env,
> -                                                 -offsetof(M68kCPU, env) +
> -                                                 offsetof(CPUState, exception_index),
> -                                                 "EXCEPTION");
> -
>       p = cpu_reg_names;
>       for (i = 0; i < 8; i++) {
>           sprintf(p, "D%d", i);



  reply	other threads:[~2025-09-24 17:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 17:13 [PATCH] target/m68k: Remove unused @cpu_exception_index TCGv Philippe Mathieu-Daudé
2025-09-24 17:24 ` Richard Henderson [this message]
2025-10-07  8:19 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a4fe7cc-9627-4a62-a51b-9435719ba21c@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).