From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58224)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1cOjym-0001Ki-9A
	for qemu-devel@nongnu.org; Wed, 04 Jan 2017 06:43:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1cOjyk-0001lE-Nt
	for qemu-devel@nongnu.org; Wed, 04 Jan 2017 06:43:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36086)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <pbonzini@redhat.com>) id 1cOjyk-0001l7-HR
	for qemu-devel@nongnu.org; Wed, 04 Jan 2017 06:43:38 -0500
References: <586cb5ab.f31d9d0a.38ac3.acf2@mx.google.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <7a63340c-2fd8-f5ec-c39c-8958b9582752@redhat.com>
Date: Wed, 4 Jan 2017 12:43:35 +0100
MIME-Version: 1.0
In-Reply-To: <586cb5ab.f31d9d0a.38ac3.acf2@mx.google.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] serial: fix memory leak in serial exit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Qiang <liq3ea@gmail.com>, mst@redhat.com, qemu-devel@nongnu.org
Cc: Li Qiang <liqiang6-s@360.cn>



On 04/01/2017 09:43, Li Qiang wrote:
> From: Li Qiang <liqiang6-s@360.cn>
> 
> The serial_exit_core function doesn't free some resources.
> This can lead memory leak when hotplug and unplug. This
> patch avoid this.
> 
> Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> ---
>  hw/char/serial.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/hw/char/serial.c b/hw/char/serial.c
> index ffbacd8..67b18ed 100644
> --- a/hw/char/serial.c
> +++ b/hw/char/serial.c
> @@ -906,6 +906,16 @@ void serial_realize_core(SerialState *s, Error **errp)
>  void serial_exit_core(SerialState *s)
>  {
>      qemu_chr_fe_deinit(&s->chr);
> +
> +    timer_del(s->modem_status_poll);
> +    timer_free(s->modem_status_poll);
> +
> +    timer_del(s->fifo_timeout_timer);
> +    timer_free(s->fifo_timeout_timer);
> +
> +    fifo8_destroy(&s->recv_fifo);
> +    fifo8_destroy(&s->xmit_fifo);
> +
>      qemu_unregister_reset(serial_reset, s);
>  }
>  
> 

Thanks, looks good.

Paolo