From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clwVU-0005UN-UR for qemu-devel@nongnu.org; Thu, 09 Mar 2017 06:45:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clwVR-0000Tu-Oz for qemu-devel@nongnu.org; Thu, 09 Mar 2017 06:45:20 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58644 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clwVR-0000Sw-JY for qemu-devel@nongnu.org; Thu, 09 Mar 2017 06:45:17 -0500 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v29BiKNt041028 for ; Thu, 9 Mar 2017 06:45:15 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 292mse51y1-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 09 Mar 2017 06:45:15 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 9 Mar 2017 11:45:13 -0000 References: <20170307025328.53409-1-haoqf@linux.vnet.ibm.com> <20170307025328.53409-2-haoqf@linux.vnet.ibm.com> <20170307092951.GA5871@noname.str.redhat.com> <80495689-674c-5dde-ae49-d80a2eb20372@linux.vnet.ibm.com> <20170307100525.GD5871@noname.str.redhat.com> <6c0b3128-37e6-8607-abab-4f655cd91426@linux.vnet.ibm.com> From: Halil Pasic Date: Thu, 9 Mar 2017 12:45:09 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Message-Id: <7a65f1b6-3767-cf0c-9d9e-a3357f14e8cc@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 1/1] vmstate: draft fix for failed iotests case 68 and 91 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QingFeng Hao , Kevin Wolf Cc: famz@redhat.com, qemu-block@nongnu.org, quintela@redhat.com, liujbjl@linux.vnet.ibm.com, qemu-devel@nongnu.org, mreitz@redhat.com, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, dgilbert@redhat.com On 03/09/2017 03:55 AM, QingFeng Hao wrote: >=20 >=20 > =E5=9C=A8 2017/3/8 19:33, Halil Pasic =E5=86=99=E9=81=93: >> >> On 03/08/2017 08:05 AM, QingFeng Hao wrote: >>> >>> =E5=9C=A8 2017/3/7 18:19, Halil Pasic =E5=86=99=E9=81=93: >>>> On 03/07/2017 11:05 AM, Kevin Wolf wrote: >>>>> Am 07.03.2017 um 10:54 hat Halil Pasic geschrieben: >>>>>> On 03/07/2017 10:29 AM, Kevin Wolf wrote: >>>>>>> Am 07.03.2017 um 03:53 hat QingFeng Hao geschrieben: [..] >>> The question is: can we do that change and what the second assert of = field's flags is used for? >> The assert is there to guard against unintended use of this nullptr-ma= rker >> mechanism. >> >> I have tested so this should work. By the way a vmstate test covering = this >> corner-case would be a good idea too (IMHO). Would you like to write o= ne? > Sorry, I don't know how to write that test case. Can you please write o= ne? > thanks! The test is just nice to have, but we definitely need the fix! Halil