From: Paolo Bonzini <pbonzini@redhat.com>
To: Qi Hu <huqi@loongson.cn>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>
Cc: qemu-devel@nongnu.org, Jinyang Shen <shenjinyang@loongson.cn>,
Xuehai Chen <chenxuehai@loongson.cn>
Subject: Re: [PATCH v3] target/i386: Fix calculation of LOCK NEG eflags
Date: Thu, 3 Nov 2022 19:40:15 +0100 [thread overview]
Message-ID: <7a77a85e-e990-aef1-60a9-91201628a758@redhat.com> (raw)
In-Reply-To: <3beb23f8-0a7b-26c0-65d8-77a552d1b61b@loongson.cn>
On 11/3/22 12:22, Qi Hu wrote:
> ping
>
> On 2022/10/24 16:41, Qi Hu wrote:
>> In sequence:
>> ---
>> lock negl -0x14(%rbp)
>> pushf
>> pop %rax
>> ---
>>
>> %rax will obtain the wrong value becasue the "lock neg" calculates the
>> wrong eflags. The "s->T0" is updated by the wrong value.
>>
>> You can use this to do some test:
>> ---
>> #include <assert.h>
>>
>> int main()
This is already part of a pull request.
Paolo
prev parent reply other threads:[~2022-11-03 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 8:41 [PATCH v3] target/i386: Fix calculation of LOCK NEG eflags Qi Hu
2022-11-03 11:22 ` Qi Hu
2022-11-03 18:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a77a85e-e990-aef1-60a9-91201628a758@redhat.com \
--to=pbonzini@redhat.com \
--cc=chenxuehai@loongson.cn \
--cc=eduardo@habkost.net \
--cc=huqi@loongson.cn \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shenjinyang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).