* [PATCH] hw/arm: Use TYPE_ARM_SMMUV3
@ 2023-01-24 23:20 Richard Henderson
2023-01-25 0:15 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Richard Henderson @ 2023-01-24 23:20 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Use the macro instead of two explicit string literals.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/arm/sbsa-ref.c | 3 ++-
hw/arm/virt.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index 4bb444684f..8378441dbb 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -29,6 +29,7 @@
#include "exec/hwaddr.h"
#include "kvm_arm.h"
#include "hw/arm/boot.h"
+#include "hw/arm/smmuv3.h"
#include "hw/block/flash.h"
#include "hw/boards.h"
#include "hw/ide/internal.h"
@@ -574,7 +575,7 @@ static void create_smmu(const SBSAMachineState *sms, PCIBus *bus)
DeviceState *dev;
int i;
- dev = qdev_new("arm-smmuv3");
+ dev = qdev_new(TYPE_ARM_SMMUV3);
object_property_set_link(OBJECT(dev), "primary-bus", OBJECT(bus),
&error_abort);
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 5f1fddd210..d103de8c2e 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1344,7 +1344,7 @@ static void create_smmu(const VirtMachineState *vms,
return;
}
- dev = qdev_new("arm-smmuv3");
+ dev = qdev_new(TYPE_ARM_SMMUV3);
object_property_set_link(OBJECT(dev), "primary-bus", OBJECT(bus),
&error_abort);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/arm: Use TYPE_ARM_SMMUV3
2023-01-24 23:20 [PATCH] hw/arm: Use TYPE_ARM_SMMUV3 Richard Henderson
@ 2023-01-25 0:15 ` Philippe Mathieu-Daudé
2023-01-25 8:11 ` Eric Auger
2023-02-02 11:45 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-01-25 0:15 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-arm
On 25/1/23 00:20, Richard Henderson wrote:
> Use the macro instead of two explicit string literals.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> hw/arm/sbsa-ref.c | 3 ++-
> hw/arm/virt.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/arm: Use TYPE_ARM_SMMUV3
2023-01-24 23:20 [PATCH] hw/arm: Use TYPE_ARM_SMMUV3 Richard Henderson
2023-01-25 0:15 ` Philippe Mathieu-Daudé
@ 2023-01-25 8:11 ` Eric Auger
2023-02-02 11:45 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Eric Auger @ 2023-01-25 8:11 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-arm
Hi,
On 1/25/23 00:20, Richard Henderson wrote:
> Use the macro instead of two explicit string literals.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> hw/arm/sbsa-ref.c | 3 ++-
> hw/arm/virt.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index 4bb444684f..8378441dbb 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -29,6 +29,7 @@
> #include "exec/hwaddr.h"
> #include "kvm_arm.h"
> #include "hw/arm/boot.h"
> +#include "hw/arm/smmuv3.h"
> #include "hw/block/flash.h"
> #include "hw/boards.h"
> #include "hw/ide/internal.h"
> @@ -574,7 +575,7 @@ static void create_smmu(const SBSAMachineState *sms, PCIBus *bus)
> DeviceState *dev;
> int i;
>
> - dev = qdev_new("arm-smmuv3");
> + dev = qdev_new(TYPE_ARM_SMMUV3);
>
> object_property_set_link(OBJECT(dev), "primary-bus", OBJECT(bus),
> &error_abort);
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 5f1fddd210..d103de8c2e 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1344,7 +1344,7 @@ static void create_smmu(const VirtMachineState *vms,
> return;
> }
>
> - dev = qdev_new("arm-smmuv3");
> + dev = qdev_new(TYPE_ARM_SMMUV3);
>
> object_property_set_link(OBJECT(dev), "primary-bus", OBJECT(bus),
> &error_abort);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/arm: Use TYPE_ARM_SMMUV3
2023-01-24 23:20 [PATCH] hw/arm: Use TYPE_ARM_SMMUV3 Richard Henderson
2023-01-25 0:15 ` Philippe Mathieu-Daudé
2023-01-25 8:11 ` Eric Auger
@ 2023-02-02 11:45 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2023-02-02 11:45 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Tue, 24 Jan 2023 at 23:21, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Use the macro instead of two explicit string literals.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> hw/arm/sbsa-ref.c | 3 ++-
> hw/arm/virt.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-02 11:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-24 23:20 [PATCH] hw/arm: Use TYPE_ARM_SMMUV3 Richard Henderson
2023-01-25 0:15 ` Philippe Mathieu-Daudé
2023-01-25 8:11 ` Eric Auger
2023-02-02 11:45 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).