qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Chenyi Qiang <chenyi.qiang@intel.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Xiaoyao Li <xiaoyao.li@intel.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] target/i386: Add bus lock debug exception support
Date: Tue, 2 Feb 2021 12:03:13 +0100	[thread overview]
Message-ID: <7aad62b9-d455-bf30-bea3-187a20578038@redhat.com> (raw)
In-Reply-To: <20210202090224.13274-1-chenyi.qiang@intel.com>

On 02/02/21 10:02, Chenyi Qiang wrote:
> Bus lock debug exception is a feature that can notify the kernel by
> generate an #DB trap after the instruction acquires a bus lock when
> CPL>0. This allows the kernel to enforce user application throttling or
> mitigations.
> 
> This feature is enumerated via CPUID.(EAX=7,ECX=0).ECX[bit 24].
> 
> Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
> ---
>   target/i386/cpu.c | 2 +-
>   target/i386/cpu.h | 2 ++
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index ae89024d36..55f3b5829f 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -963,7 +963,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>               "avx512bitalg", NULL, "avx512-vpopcntdq", NULL,
>               "la57", NULL, NULL, NULL,
>               NULL, NULL, "rdpid", NULL,
> -            NULL, "cldemote", NULL, "movdiri",
> +            "bus-lock-detect", "cldemote", NULL, "movdiri",
>               "movdir64b", NULL, NULL, NULL,
>           },
>           .cpuid = {
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index d23a5b340a..417f49b721 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -762,6 +762,8 @@ typedef uint64_t FeatureWordArray[FEATURE_WORDS];
>   #define CPUID_7_0_ECX_LA57              (1U << 16)
>   /* Read Processor ID */
>   #define CPUID_7_0_ECX_RDPID             (1U << 22)
> +/* Bus Lock Debug Exception */
> +#define CPUID_7_0_ECX_BUS_LOCK_DETECT   (1U << 24)
>   /* Cache Line Demote Instruction */
>   #define CPUID_7_0_ECX_CLDEMOTE          (1U << 25)
>   /* Move Doubleword as Direct Store Instruction */
> 

Queued, thanks.

Paolo



      reply	other threads:[~2021-02-02 11:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02  9:02 [PATCH] target/i386: Add bus lock debug exception support Chenyi Qiang
2021-02-02 11:03 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7aad62b9-d455-bf30-bea3-187a20578038@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=chenyi.qiang@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).