From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices
Date: Mon, 28 Sep 2020 10:37:52 +0200 [thread overview]
Message-ID: <7aba6fc7-6d9b-25b5-9dbf-04e15314707c@redhat.com> (raw)
In-Reply-To: <265f5d9a0fb10ce5e782455839d1baf678dbac48.1601203436.git.qemu_oss@crudebyte.com>
On 27/09/20 12:40, Christian Schoenebeck wrote:
> + qos_node_consumes("virtio-9p-device-local", "virtio-bus", &opts);
> + qos_node_produces("virtio-9p-device-local", "virtio-local");
This should produce "virtio", similar to what I remarked in the previous
patch.
> + qos_node_produces("virtio-9p-device-local", "virtio-9p-local");
> +
> + /* virtio-9p-pci-local */
> + opts.extra_device_opts = local_str_addr;
> + add_qpci_address(&opts, &addr);
> + qos_node_create_driver_named("virtio-9p-pci-local", "virtio-9p-pci",
> + virtio_9p_pci_create);
> + qos_node_consumes("virtio-9p-pci-local", "pci-bus", &opts);
> + qos_node_produces("virtio-9p-pci-local", "pci-device");
> + qos_node_produces("virtio-9p-pci-local", "virtio-local");
> + qos_node_produces("virtio-9p-pci-local", "virtio-9p-local");
> }
The implementation in patches 1 and 2 is reasonable, but what is the
advantage of this as opposed to specifying the fsdev in the edge options
for the test (similar to virtio-net)? I was expecting both
virtio-9p-device-synth and virtio-9p-device-local to produce virtio-9p,
so that the existing tests would be reused automatically by the qos
graph walk.
As things stand, I don't see any reason to have separate devices for
different backends.
Paolo
next prev parent reply other threads:[~2020-09-28 8:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 10:43 [PATCH 00/12] 9pfs: add tests using local fs driver Christian Schoenebeck
2020-09-27 10:38 ` [PATCH 01/12] tests/qtest/qgraph: add qemu_name to QOSGraphNode Christian Schoenebeck
2020-09-27 10:39 ` [PATCH 02/12] tests/qtest/qgraph: add qos_node_create_driver_named() Christian Schoenebeck
2020-09-27 10:39 ` [PATCH 03/12] tests/qtest/qos: add qos_dump_graph() Christian Schoenebeck
2020-09-27 10:39 ` [PATCH 04/12] tests/qtest/qos-test: new QTEST_DUMP_GRAPH environment variable Christian Schoenebeck
2020-09-27 10:39 ` [PATCH 05/12] tests/qtest/qos-test: add QTEST_DUMP_ENV " Christian Schoenebeck
2020-09-27 10:40 ` [PATCH 06/12] tests/qtest/qos-test: add environment variable QTEST_DEBUG Christian Schoenebeck
2020-09-28 8:31 ` Paolo Bonzini
2020-09-28 12:11 ` Christian Schoenebeck
2020-09-27 10:40 ` [PATCH 07/12] test/9pfs: change export tag name to qtest-synth Christian Schoenebeck
2020-09-27 10:40 ` [PATCH 08/12] tests/9pfs: refactor test names and test devices Christian Schoenebeck
2020-09-28 8:36 ` Paolo Bonzini
2020-09-28 8:37 ` Paolo Bonzini [this message]
2020-09-28 11:56 ` Christian Schoenebeck
2020-09-28 12:42 ` Paolo Bonzini
2020-09-28 13:35 ` Christian Schoenebeck
2020-09-28 16:38 ` Paolo Bonzini
2020-10-01 11:34 ` Christian Schoenebeck
2020-10-01 11:56 ` Paolo Bonzini
2020-10-01 12:15 ` Christian Schoenebeck
2020-10-01 14:04 ` Paolo Bonzini
2020-10-01 15:26 ` Christian Schoenebeck
2020-09-27 10:40 ` [PATCH 09/12] tests/9pfs: introduce local tests Christian Schoenebeck
2020-09-27 10:41 ` [PATCH 10/12] tests/9pfs: wipe local 9pfs test directory Christian Schoenebeck
2020-09-27 10:41 ` [PATCH 11/12] tests/9pfs: add virtio_9p_test_path() Christian Schoenebeck
2020-09-27 10:41 ` [PATCH 12/12] tests/9pfs: add local Tmkdir test Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aba6fc7-6d9b-25b5-9dbf-04e15314707c@redhat.com \
--to=pbonzini@redhat.com \
--cc=e.emanuelegiuseppe@gmail.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).