From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Patrick Venture <venture@google.com>,
pbonzini@redhat.com, peterx@redhat.com, david@redhat.com,
peter.maydell@linaro.org, richard.henderson@linaro.org
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org,
Chris Rauer <crauer@google.com>, Peter Foley <pefoley@google.com>
Subject: Re: [PATCH v2] system/memory: use ldn_he_p/stn_he_p
Date: Fri, 17 Nov 2023 09:18:46 +0100 [thread overview]
Message-ID: <7abb3a05-0779-4bb1-926c-403b50664135@linaro.org> (raw)
In-Reply-To: <20231116163633.276671-1-venture@google.com>
On 16/11/23 17:36, Patrick Venture wrote:
> Using direct pointer dereferencing can allow for unaligned accesses,
> which was seen during execution with sanitizers enabled.
>
> Reviewed-by: Chris Rauer <crauer@google.com>
> Reviewed-by: Peter Foley <pefoley@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> Cc: qemu-stable@nongnu.org
> ---
> v2: changed commit mesage to be more accurate and switched from using
> memcpy to using the endian appropriate assignment load and store.
> ---
> system/memory.c | 32 ++------------------------------
> 1 file changed, 2 insertions(+), 30 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-11-17 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 16:36 [PATCH v2] system/memory: use ldn_he_p/stn_he_p Patrick Venture
2023-11-17 8:18 ` Philippe Mathieu-Daudé [this message]
2023-11-17 8:43 ` David Hildenbrand
2023-12-03 15:42 ` Patrick Venture
2023-12-04 11:24 ` Philippe Mathieu-Daudé
2023-12-04 17:40 ` Patrick Venture
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7abb3a05-0779-4bb1-926c-403b50664135@linaro.org \
--to=philmd@linaro.org \
--cc=crauer@google.com \
--cc=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pefoley@google.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).