From: Maxim Levitsky <mlevitsk@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Eduardo Habkost <ehabkost@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH v2 0/2] Quality of life patches for qemu coroutine debugging
Date: Thu, 07 Jan 2021 20:07:57 +0200 [thread overview]
Message-ID: <7ac0aba281893693344498fb0ff926cb0a14b0f7.camel@redhat.com> (raw)
In-Reply-To: <2a1daed5-e9cf-e356-afd0-2154c787ae6c@redhat.com>
On Thu, 2021-01-07 at 19:05 +0100, Paolo Bonzini wrote:
> On 07/01/21 11:24, Maxim Levitsky wrote:
> > On Thu, 2020-12-17 at 17:54 +0200, Maxim Levitsky wrote:
> > > These are two patches that improve a bit the qemu gdb scripts in regard to
> > > coroutines.
> > >
> > > First patch fixes a bug in 'qemu coroutine' in regard to usage on non topmost
> > > stack frame.
> > >
> > > Second patch implements 'qemu bt' as Stefan suggested.
> > >
> > > V2, because after hitting 'send' I noticed a few bugs:
> > > 1. Switch to try/catch around bt, so that when regular bt fails, we
> > > print the same message as original bt.
Note that I forgot to 'git add' this bit, but it is only a cosmetic thing,
so I'll guess I'll just leave it like that.
> > > 2. Print the correct co-routine address
> > >
> > > Best regards,
> > > Maxim Levitsky
> > >
> > > Maxim Levitsky (2):
> > > scripts/gdb: fix 'qemu coroutine' when users selects a non topmost
> > > stack frame
> > > scripts/gdb: implement 'qemu bt'
> > >
> > > scripts/qemu-gdb.py | 1 +
> > > scripts/qemugdb/coroutine.py | 35 ++++++++++++++++++++++++++++++++++-
> > > 2 files changed, 35 insertions(+), 1 deletion(-)
> > >
> > > --
> > > 2.26.2
> > >
> > >
> > >
> > Any update on this?
> > Best regards,
> > Maxim Levitsky
> >
> >
>
> I'll queue them myself, thanks.
Thanks!
Best regards,
Maxim Levitsky
>
> Paolo
>
prev parent reply other threads:[~2021-01-07 18:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 15:54 [PATCH v2 0/2] Quality of life patches for qemu coroutine debugging Maxim Levitsky
2020-12-17 15:54 ` [PATCH v2 1/2] scripts/gdb: fix 'qemu coroutine' when users selects a non topmost stack frame Maxim Levitsky
2020-12-17 15:54 ` [PATCH v2 2/2] scripts/gdb: implement 'qemu bt' Maxim Levitsky
2021-01-07 10:24 ` [PATCH v2 0/2] Quality of life patches for qemu coroutine debugging Maxim Levitsky
2021-01-07 18:05 ` Paolo Bonzini
2021-01-07 18:07 ` Maxim Levitsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ac0aba281893693344498fb0ff926cb0a14b0f7.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).