From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AFF6C433DB for ; Thu, 7 Jan 2021 18:08:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0F5023370 for ; Thu, 7 Jan 2021 18:08:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0F5023370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxZiK-0003Hk-Ps for qemu-devel@archiver.kernel.org; Thu, 07 Jan 2021 13:08:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxZhg-0002oN-Oa for qemu-devel@nongnu.org; Thu, 07 Jan 2021 13:08:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:35157) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kxZhd-0006ro-FD for qemu-devel@nongnu.org; Thu, 07 Jan 2021 13:08:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610042882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JMk5ClQ37QN0I5Svh8t9fqquttBQH6nXY6eG0lkhtHo=; b=P3wCeKFQmtwVikj0TD8PiiPDP3/ZPG3b8rHs53y/mPi8NSY6N6D8vS64J6eWmL6BibqD52 5R8ZslXwNVnos+nBQ5R5hjJi1QFQpcigPAww6XAHl2QlTNHz//RP3KDQZ7hPc//IcnN7Qq 8HGx46VOc6h7TNdyiqA7PMlrVrq0mRQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-O6Dl8hmTMnuqdbMY6yqldw-1; Thu, 07 Jan 2021 13:08:01 -0500 X-MC-Unique: O6Dl8hmTMnuqdbMY6yqldw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 31E2B190B2A6; Thu, 7 Jan 2021 18:08:00 +0000 (UTC) Received: from starship (unknown [10.35.206.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id A23BF5C728; Thu, 7 Jan 2021 18:07:58 +0000 (UTC) Message-ID: <7ac0aba281893693344498fb0ff926cb0a14b0f7.camel@redhat.com> Subject: Re: [PATCH v2 0/2] Quality of life patches for qemu coroutine debugging From: Maxim Levitsky To: Paolo Bonzini , qemu-devel@nongnu.org Date: Thu, 07 Jan 2021 20:07:57 +0200 In-Reply-To: <2a1daed5-e9cf-e356-afd0-2154c787ae6c@redhat.com> References: <20201217155436.927320-1-mlevitsk@redhat.com> <2ca49172510fc5a989a222b693f3cdcee879af07.camel@redhat.com> <2a1daed5-e9cf-e356-afd0-2154c787ae6c@redhat.com> User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlevitsk@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.246, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 2021-01-07 at 19:05 +0100, Paolo Bonzini wrote: > On 07/01/21 11:24, Maxim Levitsky wrote: > > On Thu, 2020-12-17 at 17:54 +0200, Maxim Levitsky wrote: > > > These are two patches that improve a bit the qemu gdb scripts in regard to > > > coroutines. > > > > > > First patch fixes a bug in 'qemu coroutine' in regard to usage on non topmost > > > stack frame. > > > > > > Second patch implements 'qemu bt' as Stefan suggested. > > > > > > V2, because after hitting 'send' I noticed a few bugs: > > > 1. Switch to try/catch around bt, so that when regular bt fails, we > > > print the same message as original bt. Note that I forgot to 'git add' this bit, but it is only a cosmetic thing, so I'll guess I'll just leave it like that. > > > 2. Print the correct co-routine address > > > > > > Best regards, > > > Maxim Levitsky > > > > > > Maxim Levitsky (2): > > > scripts/gdb: fix 'qemu coroutine' when users selects a non topmost > > > stack frame > > > scripts/gdb: implement 'qemu bt' > > > > > > scripts/qemu-gdb.py | 1 + > > > scripts/qemugdb/coroutine.py | 35 ++++++++++++++++++++++++++++++++++- > > > 2 files changed, 35 insertions(+), 1 deletion(-) > > > > > > -- > > > 2.26.2 > > > > > > > > > > > Any update on this? > > Best regards, > > Maxim Levitsky > > > > > > I'll queue them myself, thanks. Thanks! Best regards, Maxim Levitsky > > Paolo >