From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91EF8C433E0 for ; Fri, 15 Jan 2021 18:54:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E788D2339E for ; Fri, 15 Jan 2021 18:54:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E788D2339E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0UFH-0008J7-US for qemu-devel@archiver.kernel.org; Fri, 15 Jan 2021 13:54:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0UDt-0007Sg-QP for qemu-devel@nongnu.org; Fri, 15 Jan 2021 13:53:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26616) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l0UDr-0000CT-ET for qemu-devel@nongnu.org; Fri, 15 Jan 2021 13:53:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610736801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hs0cWmPcgq2YuBckC2xYrXzEBlVUbH4Jl3cgOCnHb9k=; b=IgdzDk/S3JkgWEAmnHPU6HUJ+QqfCwFYOzjirb1n8eCK2xQu5fcYnf7n7gkbtwykRrjKNC tojBj7h0nLGAF+EeDO+wVDbmdeJMlb+Jad2B15XfHHCoFuieIqI8nd8E8JSdeufTeyq8l8 Dz/pCtRsINWkzZF7DbvEBjSBgxn4y5c= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-330-Lm-dJhBSPymFI_pNhuvGtQ-1; Fri, 15 Jan 2021 13:53:18 -0500 X-MC-Unique: Lm-dJhBSPymFI_pNhuvGtQ-1 Received: by mail-ed1-f71.google.com with SMTP id g6so4270505edw.13 for ; Fri, 15 Jan 2021 10:53:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Hs0cWmPcgq2YuBckC2xYrXzEBlVUbH4Jl3cgOCnHb9k=; b=P8A6PoqoMBG79nySu8g9THs3D6Zrv9ZRDYPX858L6Uq9RUUHRtgC+cEIY6Cdw0Dkn2 tMwdj1Bfn9VOi+M98RdMj+mAuPstu0kTEW4Lf5r6bjkd0r/oJPpJYosvOPILJX+7saah n7v12SFUgQPlWGPiOrjT8fvQRgvndtLx0CNdxw72DExYI65dvcR87S7f3OH4yaC2m2Q6 MVW8ACAKtPnjSGcg/xcWzp59whTpEmfJwZQaD0c91mFi+jDnHoJE/uTjPVfrjyiv1p/2 x6WoyQte22wtaN61y4uedXvtVBGbxopmlyWmRVN82LVXWViN78oIqPyNrz8fhcuBFPJ7 A04g== X-Gm-Message-State: AOAM5319wGLjK6KOI4H5GwsLKTCeXjQaZbYp4Cw3n0JAhnrzju9C9Q66 8YiphhWUW/xjJ/6ba9WgrtmQKp9shqJ1J9kgovaDNj4Y/n3r+u8H2g5i5YUNw+AKAXxomNWdE17 EXv/ZBEN39fJovKo= X-Received: by 2002:a50:e80c:: with SMTP id e12mr10395006edn.288.1610736797651; Fri, 15 Jan 2021 10:53:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJw02Tn2rKlqPH1aPRV9Gu7hQnp/jhC9q9sW8PZw+TSqGOUezis+TqF8pUWEHF3l4HKRAAd2JQ== X-Received: by 2002:a50:e80c:: with SMTP id e12mr10394995edn.288.1610736797464; Fri, 15 Jan 2021 10:53:17 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id cb14sm4220305ejb.105.2021.01.15.10.53.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jan 2021 10:53:16 -0800 (PST) Subject: Re: [RFC PATCH] meson: Only install ROMs when building system emulation binaries To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210115175135.3402714-1-philmd@redhat.com> From: Paolo Bonzini Message-ID: <7acbc6ab-c97d-ada4-8ce2-481b6000b5b6@redhat.com> Date: Fri, 15 Jan 2021 19:53:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210115175135.3402714-1-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 15/01/21 18:51, Philippe Mathieu-Daudé wrote: > It is pointless to install ROM blobs for user emulation. > > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC because I think it would be better to make the 'blobs' > option a 'feature' instead of a boolean so we can set it > as 'auto' and then in that case we could do something Yes it's better to do that and have install_blobs = get_option('install_blobs').enabled() or (get_option('install_blobs').auto() and have_system) And then if get_option('install_blobs').auto() you could install blobs only if the corresponding target is included in target_dirs: if get_option('install_blobs').enabled() or 'i386-softmmu' in target_dirs or 'x86_64-softmmu' in target_dirs ... endif Paolo > blobs = have_system > > because currently ./configure still displays: > > Install blobs: YES > > which is confusing. > --- > meson.build | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 954152c90fe..273b8e6baa9 100644 > --- a/meson.build > +++ b/meson.build > @@ -2254,7 +2254,9 @@ > > subdir('scripts') > subdir('tools') > -subdir('pc-bios') > +if have_system > + subdir('pc-bios') > +endif > subdir('docs') > subdir('tests') > if gtk.found() >