From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE513C77B73 for ; Wed, 31 May 2023 09:11:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4Hqw-0008De-80; Wed, 31 May 2023 05:10:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Hqr-00087W-CZ; Wed, 31 May 2023 05:10:41 -0400 Received: from proxmox-new.maurer-it.com ([94.136.29.106]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Hqm-00033K-PJ; Wed, 31 May 2023 05:10:41 -0400 Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2F3FB47E42; Wed, 31 May 2023 11:10:26 +0200 (CEST) Message-ID: <7acf22e1-6687-a633-2639-bae88f516354@proxmox.com> Date: Wed, 31 May 2023 11:10:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 00/20] Next round of migration atomic counters To: Juan Quintela , qemu-devel@nongnu.org Cc: Leonardo Bras , Hailiang Zhang , Peter Xu , Stefan Hajnoczi , qemu-block@nongnu.org, Fam Zheng References: <20230530183941.7223-1-quintela@redhat.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20230530183941.7223-1-quintela@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=94.136.29.106; envelope-from=f.ebner@proxmox.com; helo=proxmox-new.maurer-it.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.09, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 30.05.23 um 20:39 schrieb Juan Quintela: > Hi > > On this v2: > > - dropped qemu_fflush() assert for read only files (make Richard > happy) > > - Update documentation for qemu_file_transferred (make Fabiano happy) > > - migration/rdma: Remove qemu_fopen_rdma() and make it look like > everything else > > - Simplify a couple of qemu-file functions, and unexport the ones that > are not used outside of qemu-file.c > > - Added Reviewed-by comments. > > Please review. > Hi, I don't notice any performance regression with snapshots anymore with this series :) Note that I had to apply your PULL patches from yesterday too, to be able to apply this series: https://lists.nongnu.org/archive/html/qemu-devel/2023-05/msg07361.html Best Regards, Fiona