From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>, qemu-devel@nongnu.org
Cc: fam@euphon.net, alex.bennee@linaro.org, crosa@redhat.com
Subject: Re: [PATCH 2/2] travis.yml: Detach build and test steps
Date: Tue, 31 Dec 2019 18:10:15 +0100 [thread overview]
Message-ID: <7ad5bf7b-9640-b617-2251-4e4b29f0d7f7@redhat.com> (raw)
In-Reply-To: <20191230184327.2800-3-wainersm@redhat.com>
On 12/30/19 7:43 PM, Wainer dos Santos Moschetta wrote:
> Currently build and test commands are a single step in a
> Travis's `script` block. In order to see the output
> of the tests one needs to scroll down the log to find where
> the build messages ended and the limit is not clear. If
> they were in different steps then Travis would print the
> result build command, which can be easily grep'ed.
>
> So this change is made to detach those commands
> to ease the visualization of the output.
>
> Note that all steps on the `script` block is executed regardless
> if one previous has failed. To overcome it, let's save the
> return code of the build then check whether succeed or failed on
> the test step.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested with a broken test:
https://travis-ci.org/philmd/qemu/jobs/631341382
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
> .travis.yml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index e7fdcb238c..fcc9de368b 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -94,7 +94,8 @@ before_script:
> - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR}
> - ${SRC_DIR}/configure ${BASE_CONFIG} ${CONFIG} || { cat config.log && exit 1; }
> script:
> - - make -j3 && travis_retry ${TEST_CMD}
> + - BUILD_RC=0 && make -j3 || BUILD_RC=$?
> + - if [ "$BUILD_RC" -eq 0 ] ; then travis_retry ${TEST_CMD} ; else $(exit $BUILD_RC); fi
> after_script:
> - if command -v ccache ; then ccache --show-stats ; fi
>
>
prev parent reply other threads:[~2019-12-31 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 18:43 [PATCH 0/2] travis: Improve log browseability Wainer dos Santos Moschetta
2019-12-30 18:43 ` [PATCH 1/2] travis.yml: avocado: Print logs of non-pass tests only Wainer dos Santos Moschetta
2019-12-31 17:08 ` Philippe Mathieu-Daudé
2020-01-07 11:20 ` Alex Bennée
2020-01-09 13:27 ` Wainer dos Santos Moschetta
2019-12-30 18:43 ` [PATCH 2/2] travis.yml: Detach build and test steps Wainer dos Santos Moschetta
2019-12-31 17:10 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ad5bf7b-9640-b617-2251-4e4b29f0d7f7@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=fam@euphon.net \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).