From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: phil@philjordan.eu, qemu-devel@nongnu.org
Cc: Cameron Esfahani <dirty@apple.com>,
Roman Bolshakov <rbolshakov@ddn.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Alexander Graf <agraf@csgraf.de>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org
Subject: Re: [PATCH 10/11] hw/intc/apic: Fixes magic number use, removes outdated comment
Date: Mon, 9 Dec 2024 21:55:37 +0100 [thread overview]
Message-ID: <7ad94711-21b7-4350-a340-351ceef0438d@linaro.org> (raw)
In-Reply-To: <20241209203629.74436-11-phil@philjordan.eu>
On 9/12/24 21:36, phil@philjordan.eu wrote:
> From: Phil Dennis-Jordan <phil@philjordan.eu>
>
> This changes replaces the use of an explicit literal constant for
> the APIC base address mask with the existing symbolic constant
> intended for this purpose.
>
> Additionally, we remove the comment about not being able to
> re-enable the APIC after disabling it. This is no longer
> the case after the APIC implementation's state machine was
> modified in 9.0.
>
> Signed-off-by: Phil Dennis-Jordan <phil@philjordan.eu>
> ---
> hw/intc/apic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-12-09 20:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 20:36 [PATCH 00/11] hvf and APIC fixes, improvements, and optimisations phil
2024-12-09 20:36 ` [PATCH 01/11] hvf: Add facility for initialisation code prior to first vCPU run phil
2024-12-10 10:05 ` Alexander Graf
2025-02-05 21:02 ` Philippe Mathieu-Daudé
2025-02-09 19:45 ` Phil Dennis-Jordan
2024-12-09 20:36 ` [PATCH 02/11] arm/hvf: Initialise GICv3 state just before " phil
2024-12-10 10:05 ` Alexander Graf
2025-02-05 14:47 ` Zenghui Yu
2024-12-09 20:36 ` [PATCH 03/11] i386/hvf: Don't send signal to thread when kicking phil
2024-12-09 21:22 ` Philippe Mathieu-Daudé
2024-12-10 8:17 ` Phil Dennis-Jordan
2024-12-10 9:21 ` Roman Bolshakov
2024-12-10 9:52 ` Phil Dennis-Jordan
2025-02-05 20:58 ` Philippe Mathieu-Daudé
2024-12-09 20:36 ` [PATCH 04/11] i386/hvf: Pre-fetch emulated instructions phil
2024-12-09 20:36 ` [PATCH 05/11] i386/hvf: Decode APIC access x86 instruction outside BQL phil
2024-12-09 20:36 ` [PATCH 06/11] i386/hvf: APIC access exit with fast-path for common mov cases phil
2024-12-09 20:36 ` [PATCH 07/11] i386/hvf: Enables APIC_ACCESS VM exits by setting APICBASE phil
2024-12-09 20:36 ` [PATCH 08/11] i386/hvf: Variable type fixup in decoder phil
2024-12-09 20:49 ` Philippe Mathieu-Daudé
2024-12-09 20:36 ` [PATCH 09/11] i386/hvf: Print hex pairs for each opcode byte in decode error phil
2024-12-09 20:54 ` Philippe Mathieu-Daudé
2024-12-10 11:28 ` Phil Dennis-Jordan
2024-12-09 20:36 ` [PATCH 10/11] hw/intc/apic: Fixes magic number use, removes outdated comment phil
2024-12-09 20:55 ` Philippe Mathieu-Daudé [this message]
2024-12-09 20:36 ` [PATCH 11/11] hw/intc/apic: Raise exception when setting reserved APICBASE bits phil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ad94711-21b7-4350-a340-351ceef0438d@linaro.org \
--to=philmd@linaro.org \
--cc=agraf@csgraf.de \
--cc=dirty@apple.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).