qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	Daniel Henrique Barboza <danielhb413@gmail.com>,
	Bernhard Beschow <shentey@gmail.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	ReneEngel80@emailn.de
Subject: Re: [PATCH v5 2/7] Revert "hw/isa/vt82c686: Remove intermediate IRQ forwarder"
Date: Thu, 2 Mar 2023 11:41:43 +0100	[thread overview]
Message-ID: <7ae0ae69-817e-7100-beed-ed610b3135cb@linaro.org> (raw)
In-Reply-To: <709f5780-97e5-0cee-d776-4558cf39e000@eik.bme.hu>

On 1/3/23 01:33, BALATON Zoltan wrote:
> On Wed, 1 Mar 2023, BALATON Zoltan wrote:
>> This partially reverts commit bb98e0f59cde846666d9fddc60ae74ef7ddfca17
>> keeping the rename of a state field but reverting other cahanges which
>> break interrupts on pegasos2.
> 
> I've found this with just booting the MorphOS iso which now hangs 
> without this revert when trying to read from the ide device.

Can you add an Avocado test booting the MorphOS iso?

> I think 
> I've mentioned that I've also tried this way first but then ended up 
> adding this because it was needed in a review of the patch earlier but I 
> can't find that message now. For now it seems the easiest is to revert 
> this and think about it later.
> 
> Regards,
> BALATON Zoltan
> 
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> hw/isa/vt82c686.c | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)


  parent reply	other threads:[~2023-03-02 10:42 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01  0:17 [PATCH v5 0/7] Pegasos2 fixes and audio output support BALATON Zoltan
2023-03-01  0:17 ` [PATCH v5 1/7] hw/display/sm501: Add debug property to control pixman usage BALATON Zoltan
2023-03-02 21:51   ` BALATON Zoltan
2023-03-01  0:17 ` [PATCH v5 2/7] Revert "hw/isa/vt82c686: Remove intermediate IRQ forwarder" BALATON Zoltan
2023-03-01  0:33   ` BALATON Zoltan
2023-03-01  6:43     ` Bernhard Beschow
2023-03-01 11:17       ` BALATON Zoltan
2023-03-02 10:41     ` Philippe Mathieu-Daudé [this message]
2023-03-02 10:44       ` Philippe Mathieu-Daudé
2023-03-02 12:37       ` BALATON Zoltan
2023-03-02 12:46         ` Philippe Mathieu-Daudé
2023-03-01  0:17 ` [PATCH v5 3/7] hw/isa/vt82c686: Implement PCI IRQ routing BALATON Zoltan
2023-03-01  6:38   ` Bernhard Beschow
2023-03-01 11:15     ` BALATON Zoltan
2023-03-01 21:08       ` Bernhard Beschow
2023-03-01 21:27         ` BALATON Zoltan
2023-03-01  0:17 ` [PATCH v5 4/7] hw/ppc/pegasos2: Fix PCI interrupt routing BALATON Zoltan
2023-03-03  9:17   ` Daniel Henrique Barboza
2023-03-01  0:17 ` [PATCH v5 5/7] hw/isa/vt82c686: Work around missing level sensitive irq in i8259 model BALATON Zoltan
2023-03-01  6:49   ` Bernhard Beschow
2023-03-01 11:27     ` BALATON Zoltan
2023-03-01 11:52       ` David Woodhouse
2023-03-01 13:18         ` BALATON Zoltan
2023-03-01 14:05           ` David Woodhouse
2023-03-01 18:01             ` BALATON Zoltan
2023-03-01 21:53               ` David Woodhouse
2023-03-01 22:47                 ` BALATON Zoltan
2023-03-02  8:59                   ` David Woodhouse
2023-03-02  9:06                     ` [PATCH] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank Select David Woodhouse
2023-03-02  9:58                       ` David Woodhouse
2023-03-02 12:35                       ` BALATON Zoltan
2023-03-02 21:46                     ` [PATCH v5 5/7] hw/isa/vt82c686: Work around missing level sensitive irq in i8259 model BALATON Zoltan
2023-03-01 20:58             ` Bernhard Beschow
2023-03-01  0:17 ` [PATCH v5 6/7] hw/usb/vt82c686-uhci-pci: Use PCI IRQ routing BALATON Zoltan
2023-03-01  0:17 ` [PATCH v5 7/7] hw/audio/via-ac97: Basic implementation of audio playback BALATON Zoltan
2023-03-02 21:59   ` BALATON Zoltan
2023-03-03  6:57   ` Volker Rümelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ae0ae69-817e-7100-beed-ed610b3135cb@linaro.org \
    --to=philmd@linaro.org \
    --cc=ReneEngel80@emailn.de \
    --cc=balaton@eik.bme.hu \
    --cc=danielhb413@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=shentey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).