From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1900AC433EF for ; Thu, 16 Sep 2021 14:08:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8895161241 for ; Thu, 16 Sep 2021 14:08:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8895161241 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQs4O-0005U1-O5 for qemu-devel@archiver.kernel.org; Thu, 16 Sep 2021 10:08:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs28-0002Cx-Nq for qemu-devel@nongnu.org; Thu, 16 Sep 2021 10:06:38 -0400 Received: from 10.mo548.mail-out.ovh.net ([46.105.77.235]:35453) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs25-0002CS-Kq for qemu-devel@nongnu.org; Thu, 16 Sep 2021 10:06:36 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.108.20.2]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 476C41FEE7; Thu, 16 Sep 2021 14:06:29 +0000 (UTC) Received: from kaod.org (37.59.142.99) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 16 Sep 2021 16:06:28 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-99G0034cf39797-09a8-4990-8343-34599739d5cc, 902CC554B2B666CF336F93082A9AEA4058B2700C) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <7ae560b5-e719-0b6d-1fdc-b231af9d6a81@kaod.org> Date: Thu, 16 Sep 2021 16:06:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Richard Henderson , Peter Maydell , Joel Stanley References: <20210913161304.3805652-1-clg@kaod.org> <20210913161304.3805652-15-clg@kaod.org> <88c26520-6b87-e7a2-ac78-c1c92477c814@kaod.org> <1949e204-1bce-f15b-553b-1b42b41e3e08@linaro.org> <1d6fb312-ab21-ca9c-d7ec-1043ccc65b10@amsat.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <1d6fb312-ab21-ca9c-d7ec-1043ccc65b10@amsat.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.99] X-ClientProxiedBy: DAG3EX2.mxp5.local (172.16.2.22) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 708cef0f-6b27-45bd-92a7-cd70bd34d47c X-Ovh-Tracer-Id: 5720978902582528876 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvtddrudehgedgieejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepieegvdffkeegfeetuddttddtveduiefhgeduffekiedtkeekteekhfffleevleelnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrdelleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohepphguvghlsehfsgdrtghomh Received-SPF: pass client-ip=46.105.77.235; envelope-from=clg@kaod.org; helo=10.mo548.mail-out.ovh.net X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.488, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , "qemu-arm@nongnu.org" , "qemu-devel@nongnu.org" , Peter Delevoryas Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/16/21 15:53, Philippe Mathieu-Daudé wrote: > On 9/16/21 2:29 PM, Cédric Le Goater wrote: >> On 9/14/21 17:22, Richard Henderson wrote: >>> On 9/14/21 5:26 AM, Peter Maydell wrote: >>>> (2) RAM blocks should have a length that fits inside a >>>>      signed 32-bit type on 32-bit hosts (at least I assume this >>>>      is where the 2047MB limit is coming from; in theory this ought >>>>      to be improveable but auditing the code for mishandling of >>>>      RAMblock sizes to ensure we weren't accidentally stuffing >>>>      their size into a signed 'long' somewhere would be kind >>>>      of painful) > >>>> Even if we did fix (2) we'd need to compromise on (3) >>>> sometimes still -- if a board has 4GB of RAM that's >>>> not going to fit in 32 bits regardless. But we would be >>>> able to let boards with 2GB have 2GB. >>> >>> I'm not opposed to deprecating 32-bit hosts...  ;-) >> >> Until then, I am willing to make the following compromise for the fuji  : >> >>     mc->default_ram_size = (HOST_LONG_BITS == 32 ? 1 : 2) * GiB; > > While I disagree with this approach, better to document it clearly > like commit 25ff112a8cc ("hw/arm/mps2-tz: Add new mps3-an524 board"). > OK. The patch I had prepared was a bit more explicit : /* On 32-bit hosts, lower RAM to 1G because of 2047 MB limit */ mc->default_ram_size = (HOST_LONG_BITS == 32 ? 1 : 2) * GiB; I even have a version with a warn_report() since 32-bit hosts are not that common these days. But let's adopt the mps3-an524 board approach. Thanks, C.