Re: [PATCH 1/2] tests: Make iotest 223 easier to edit

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 864 bytes --]

On 24.09.19 16:35, Eric Blake wrote:
> Log the QMP input to qemu, not just the QMP output.

Why not just add this functionality to _send_qemu_cmd directly?  (Like
silent already does for replies, although it’s inverted.)

(Although I’m not quite sold on the indentation for commands, because
(1) we don’t do that in other tests, (2) I’d prefer some prefix like
->/<-, and (3) there is generally no need because commands start with
“execute” and replies start with “return”, “error”, or “event”, so they
already have clear prefixes to distinguish the two classes.)

Max

> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  tests/qemu-iotests/223     | 48 +++++++++++++++++++++-----------------
>  tests/qemu-iotests/223.out | 40 +++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+), 21 deletions(-)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]