From: Laurent Vivier <laurent@vivier.eu>
To: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Nicer strace output of chroot() syscall
Date: Wed, 6 Mar 2019 13:49:16 +0100 [thread overview]
Message-ID: <7afb1707-afce-eb0b-d554-8168c168ce71@vivier.eu> (raw)
In-Reply-To: <20190227191115.GA20163@ls3530.dellerweb.de>
On 27/02/2019 20:11, Helge Deller wrote:
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 7318392e57..6f72a74c09 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -1235,6 +1235,18 @@ print_chdir(const struct syscallname *name,
> }
> #endif
>
> +#ifdef TARGET_NR_chroot
> +static void
> +print_chroot(const struct syscallname *name,
> + abi_long arg0, abi_long arg1, abi_long arg2,
> + abi_long arg3, abi_long arg4, abi_long arg5)
> +{
> + print_syscall_prologue(name);
> + print_string(arg0, 1);
> + print_syscall_epilogue(name);
> +}
> +#endif
> +
> #ifdef TARGET_NR_chmod
> static void
> print_chmod(const struct syscallname *name,
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index ff8bb19f5f..db21ce4177 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -77,7 +77,7 @@
> { TARGET_NR_chown32, "chown32" , NULL, NULL, NULL },
> #endif
> #ifdef TARGET_NR_chroot
> -{ TARGET_NR_chroot, "chroot" , NULL, NULL, NULL },
> +{ TARGET_NR_chroot, "chroot" , NULL, print_chroot, NULL },
> #endif
> #ifdef TARGET_NR_clock_adjtime
> { TARGET_NR_clock_adjtime, "clock_adjtime" , NULL, print_clock_adjtime, NULL },
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2019-03-06 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 19:11 [Qemu-devel] [PATCH] linux-user: Nicer strace output of chroot() syscall Helge Deller
2019-03-06 12:49 ` Laurent Vivier [this message]
2019-03-06 13:13 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7afb1707-afce-eb0b-d554-8168c168ce71@vivier.eu \
--to=laurent@vivier.eu \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).