From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org,
andrey.shinkevich@virtuozzo.com, qemu-devel@nongnu.org,
mreitz@redhat.com
Subject: Re: [PATCH v4 01/12] qcow2.py: python style fixes
Date: Fri, 5 Jun 2020 14:43:37 -0500 [thread overview]
Message-ID: <7b0ae96a-e52f-d75d-cd17-e681258874b7@redhat.com> (raw)
In-Reply-To: <20200604174135.11042-2-vsementsov@virtuozzo.com>
On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote:
> Fix flake8 complains. Leave the only chunk of lines over 79 characters:
complaints
> initialization of cmds variable. Leave it for another day, when it
> should be refactored to utilize argparse instead of hand-written
> parsing.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> tests/qemu-iotests/qcow2.py | 92 +++++++++++++++++++++----------------
> 1 file changed, 53 insertions(+), 39 deletions(-)
>
> cmds = [
> - [ 'dump-header', cmd_dump_header, 0, 'Dump image header and header extensions' ],
> - [ 'dump-header-exts', cmd_dump_header_exts, 0, 'Dump image header extensions' ],
> - [ 'set-header', cmd_set_header, 2, 'Set a field in the header'],
> - [ 'add-header-ext', cmd_add_header_ext, 2, 'Add a header extension' ],
> - [ 'add-header-ext-stdio', cmd_add_header_ext_stdio, 1, 'Add a header extension, data from stdin' ],
> - [ 'del-header-ext', cmd_del_header_ext, 1, 'Delete a header extension' ],
> - [ 'set-feature-bit', cmd_set_feature_bit, 2, 'Set a feature bit'],
> + ['dump-header', cmd_dump_header, 0, 'Dump image header and header extensions'],
I know you mentioned argparse as a later refactoring, but is it worth
reflowing the table in the meantime?
['dump-header', cmd_dump_header, 0,
'Dump image header and header extensions'],
[...
'...'],
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-06-05 19:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 17:41 [PATCH v4 00/12] iotests: Dump QCOW2 dirty bitmaps metadata Vladimir Sementsov-Ogievskiy
2020-06-04 17:41 ` [PATCH v4 01/12] qcow2.py: python style fixes Vladimir Sementsov-Ogievskiy
2020-06-05 10:23 ` Andrey Shinkevich
2020-06-05 19:43 ` Eric Blake [this message]
2020-06-06 7:00 ` Vladimir Sementsov-Ogievskiy
2020-06-04 17:41 ` [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module Vladimir Sementsov-Ogievskiy
2020-06-05 10:51 ` Andrey Shinkevich
2020-06-05 20:14 ` Eric Blake
2020-06-06 7:03 ` Vladimir Sementsov-Ogievskiy
2020-06-08 15:20 ` Eric Blake
2020-06-04 17:41 ` [PATCH v4 03/12] qcow2_format.py: drop new line printing at end of dump() Vladimir Sementsov-Ogievskiy
2020-06-05 10:54 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields Vladimir Sementsov-Ogievskiy
2020-06-05 11:20 ` Andrey Shinkevich
2020-06-05 20:16 ` Eric Blake
2020-06-06 7:07 ` Vladimir Sementsov-Ogievskiy
2020-06-04 17:41 ` [PATCH v4 05/12] qcow2_format.py: use modern string formatting Vladimir Sementsov-Ogievskiy
2020-06-05 11:27 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 06/12] qcow2_format.py: use strings to specify c-type of struct fields Vladimir Sementsov-Ogievskiy
2020-06-05 11:36 ` Andrey Shinkevich
2020-06-05 20:19 ` Eric Blake
2020-06-04 17:41 ` [PATCH v4 07/12] qcow2_format.py: separate generic functionality of structure classes Vladimir Sementsov-Ogievskiy
2020-06-05 12:29 ` Andrey Shinkevich
2020-06-05 12:37 ` Vladimir Sementsov-Ogievskiy
2020-06-04 17:41 ` [PATCH v4 08/12] qcow2_format.py: add field-formatting class Vladimir Sementsov-Ogievskiy
2020-06-05 13:27 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 09/12] qcow2_format.py: QcowHeaderExtension: add dump method Vladimir Sementsov-Ogievskiy
2020-06-05 14:43 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 10/12] qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Struct Vladimir Sementsov-Ogievskiy
2020-06-05 15:30 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 11/12] qcow2: QcowHeaderExtension print names for extension magics Vladimir Sementsov-Ogievskiy
2020-06-05 15:42 ` Andrey Shinkevich
2020-06-05 16:26 ` Vladimir Sementsov-Ogievskiy
2020-06-05 16:41 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 12/12] qcow2_format.py: dump bitmaps header extension Vladimir Sementsov-Ogievskiy
2020-06-05 16:06 ` Andrey Shinkevich
2020-06-04 19:14 ` [PATCH v4 00/12] iotests: Dump QCOW2 dirty bitmaps metadata no-reply
2020-06-05 10:02 ` Vladimir Sementsov-Ogievskiy
2020-06-05 20:50 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b0ae96a-e52f-d75d-cd17-e681258874b7@redhat.com \
--to=eblake@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).