qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Shalini Chellathurai Saroja <shalini@linux.ibm.com>,
	qemu-s390x mailing list <qemu-s390x@nongnu.org>
Cc: Daniel Berrange <berrange@redhat.com>,
	qemu-devel mailing list <qemu-devel@nongnu.org>,
	Nina Schoetterl-Glausch <nsg@linux.ibm.com>,
	Hendrik Brueckner <brueckner@linux.ibm.com>
Subject: Re: [PATCH RFC] tests/functional: add tests for SCLP event CPI
Date: Mon, 25 Aug 2025 13:30:46 +0200	[thread overview]
Message-ID: <7b1222ef-df18-4770-b218-b71cacb441e9@redhat.com> (raw)
In-Reply-To: <20250812123124.382696-1-shalini@linux.ibm.com>

On 12/08/2025 14.31, Shalini Chellathurai Saroja wrote:
> Add tests for SCLP event type Control-Program Identification
> (CPI) to s390x CCW virtio tests.
> 
> Please note that these tests are skipped as the guest OS does not
> trigger the SCLP event type CPI when the command
> 'echo 1 > /sys/firmware/cpi/set' is executed in the guest. I
> believe that the guest OS must to be updated to support the SCLP
> event type CPI.
> 
> Signed-off-by: Shalini Chellathurai Saroja <shalini@linux.ibm.com>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> ---
...
> +        try:
> +            event = self.vm.event_wait('SCLP_EVENT_CTRL_PGM_ID')

As far as I can tell, SCLP_EVENT_CTRL_PGM_ID is an *SCLP* event only, but 
you're trying to wait for a *QAPI* event here instead. That's two completely 
different things, SCLP events are something between the guest and QEMU, 
while QAPI events are between QEMU and the monitoring program (i.e. in this 
case the test).

If you want that QEMU generates such QAPI events for the monitoring program, 
you have to do something similar to commit 1cfe52b78240679 and add the 
qapi_event_send_... function to the right spot in your code.

  HTH,
   Thomas



  reply	other threads:[~2025-08-25 11:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12 12:31 [PATCH RFC] tests/functional: add tests for SCLP event CPI Shalini Chellathurai Saroja
2025-08-25 11:30 ` Thomas Huth [this message]
2025-10-13 13:37   ` Shalini Chellathurai Saroja
2025-09-11  9:05 ` Nina Schoetterl-Glausch
2025-09-11  9:21   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b1222ef-df18-4770-b218-b71cacb441e9@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=brueckner@linux.ibm.com \
    --cc=nsg@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=shalini@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).