qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: elena.ufimtseva@oracle.com
To: qemu-devel@nongnu.org
Cc: elena.ufimtseva@oracle.com, fam@euphon.net,
	swapnil.ingle@nutanix.com, john.g.johnson@oracle.com,
	kraxel@redhat.com, jag.raman@oracle.com, quintela@redhat.com,
	mst@redhat.com, armbru@redhat.com, kanth.ghatraju@oracle.com,
	felipe@nutanix.com, thuth@redhat.com, ehabkost@redhat.com,
	konrad.wilk@oracle.com, dgilbert@redhat.com,
	liran.alon@oracle.com, stefanha@redhat.com,
	thanos.makatos@nutanix.com, rth@twiddle.net, kwolf@redhat.com,
	berrange@redhat.com, mreitz@redhat.com,
	ross.lagerwall@citrix.com, marcandre.lureau@gmail.com,
	pbonzini@redhat.com
Subject: [PATCH v6 15/36] multi-process: setup memory manager for remote device
Date: Mon,  6 Apr 2020 02:41:05 -0700	[thread overview]
Message-ID: <7b1614ac098dd88b32dd06a2d7e17f7d1b85492c.1586165556.git.elena.ufimtseva@oracle.com> (raw)
In-Reply-To: <cover.1586165555.git.elena.ufimtseva@oracle.com>

From: Jagannathan Raman <jag.raman@oracle.com>

sync_sysmem_msg_t message format is defined. It is used to send
file descriptors of the RAM regions to remote device.
RAM on the remote device is configured with a set of file descriptors.
Old RAM regions are deleted and new regions, each with an fd, is
added to the RAM.

Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
---
 MAINTAINERS              |  2 ++
 Makefile.target          |  2 ++
 exec.c                   | 17 +++++++++++
 include/exec/ram_addr.h  |  2 ++
 include/io/mpqemu-link.h | 12 ++++++++
 include/remote/memory.h  | 20 +++++++++++++
 io/mpqemu-link.c         | 13 +++++++++
 remote/memory.c          | 63 ++++++++++++++++++++++++++++++++++++++++
 8 files changed, 131 insertions(+)
 create mode 100644 include/remote/memory.h
 create mode 100644 remote/memory.c

diff --git a/MAINTAINERS b/MAINTAINERS
index 970cdfc2ef..7b46ec2e71 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2823,6 +2823,8 @@ F: include/remote/pcihost.h
 F: remote/pcihost.c
 F: include/remote/machine.h
 F: remote/machine.c
+F: include/remote/memory.h
+F: remote/memory.c
 
 Build and test automation
 -------------------------
diff --git a/Makefile.target b/Makefile.target
index 70fa1eeca5..500fa07fda 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -143,6 +143,8 @@ remote-pci-tgt-obj-$(CONFIG_MPQEMU) += stubs/replay.o
 remote-pci-tgt-obj-$(CONFIG_MPQEMU) += stubs/xen-mapcache.o
 remote-pci-tgt-obj-$(CONFIG_MPQEMU) += stubs/audio.o
 remote-pci-tgt-obj-$(CONFIG_MPQEMU) += stubs/monitor.o
+
+remote-pci-tgt-obj-$(CONFIG_MPQEMU) += remote/memory.o
 endif
 
 #########################################################
diff --git a/exec.c b/exec.c
index 3bdad9d058..523e77dd09 100644
--- a/exec.c
+++ b/exec.c
@@ -2359,6 +2359,23 @@ RAMBlock *qemu_ram_alloc_from_file(ram_addr_t size, MemoryRegion *mr,
 
     return block;
 }
+
+void qemu_ram_init_from_fd(MemoryRegion *mr, int fd, uint64_t size,
+                           ram_addr_t offset, Error **errp)
+{
+    char *name = g_strdup_printf("%d", fd);
+
+    memory_region_init(mr, NULL, name, size);
+    mr->ram = true;
+    mr->terminates = true;
+    mr->destructor = NULL;
+    mr->align = 0;
+    mr->ram_block = qemu_ram_alloc_from_fd(size, mr, RAM_SHARED, fd, offset,
+                                           errp);
+    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
+
+    g_free(name);
+}
 #endif
 
 static
diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
index 1b9f489ff0..d9d7314f51 100644
--- a/include/exec/ram_addr.h
+++ b/include/exec/ram_addr.h
@@ -122,6 +122,8 @@ RAMBlock *qemu_ram_alloc_from_file(ram_addr_t size, MemoryRegion *mr,
 RAMBlock *qemu_ram_alloc_from_fd(ram_addr_t size, MemoryRegion *mr,
                                  uint32_t ram_flags, int fd,
                                  off_t offset, Error **errp);
+void qemu_ram_init_from_fd(MemoryRegion *mr, int fd, uint64_t size,
+                           ram_addr_t offset, Error **errp);
 
 RAMBlock *qemu_ram_alloc_from_ptr(ram_addr_t size, void *host,
                                   MemoryRegion *mr, Error **errp);
diff --git a/include/io/mpqemu-link.h b/include/io/mpqemu-link.h
index ef95599bca..d46cb81058 100644
--- a/include/io/mpqemu-link.h
+++ b/include/io/mpqemu-link.h
@@ -16,6 +16,8 @@
 
 #include "qom/object.h"
 #include "qemu/thread.h"
+#include "exec/cpu-common.h"
+#include "exec/hwaddr.h"
 
 #define TYPE_MPQEMU_LINK "mpqemu-link"
 #define MPQEMU_LINK(obj) \
@@ -27,15 +29,23 @@
 
 /**
  * mpqemu_cmd_t:
+ * SYNC_SYSMEM      Shares QEMU's RAM with remote device's RAM
  *
  * proc_cmd_t enum type to specify the command to be executed on the remote
  * device.
  */
 typedef enum {
     INIT = 0,
+    SYNC_SYSMEM,
     MAX,
 } mpqemu_cmd_t;
 
+typedef struct {
+    hwaddr gpas[REMOTE_MAX_FDS];
+    uint64_t sizes[REMOTE_MAX_FDS];
+    ram_addr_t offsets[REMOTE_MAX_FDS];
+} sync_sysmem_msg_t;
+
 /**
  * MPQemuMsg:
  * @cmd: The remote command
@@ -49,6 +59,7 @@ typedef enum {
  * MPQemuMsg Format of the message sent to the remote device from QEMU.
  *
  */
+
 typedef struct {
     mpqemu_cmd_t cmd;
     int bytestream;
@@ -56,6 +67,7 @@ typedef struct {
 
     union {
         uint64_t u64;
+        sync_sysmem_msg_t sync_sysmem;
     } data1;
 
     int fds[REMOTE_MAX_FDS];
diff --git a/include/remote/memory.h b/include/remote/memory.h
new file mode 100644
index 0000000000..e2e479bb6f
--- /dev/null
+++ b/include/remote/memory.h
@@ -0,0 +1,20 @@
+/*
+ * Memory manager for remote device
+ *
+ * Copyright © 2018, 2020 Oracle and/or its affiliates.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ *
+ */
+
+#ifndef REMOTE_MEMORY_H
+#define REMOTE_MEMORY_H
+
+#include "qemu/osdep.h"
+#include "exec/hwaddr.h"
+#include "io/mpqemu-link.h"
+
+void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp);
+
+#endif
diff --git a/io/mpqemu-link.c b/io/mpqemu-link.c
index fa9b3a66b1..330a6deffe 100644
--- a/io/mpqemu-link.c
+++ b/io/mpqemu-link.c
@@ -348,6 +348,19 @@ bool mpqemu_msg_valid(MPQemuMsg *msg)
             }
         }
     }
+     /* Verify message specific fields. */
+    switch (msg->cmd) {
+    case SYNC_SYSMEM:
+        if (msg->num_fds == 0 || msg->bytestream != 0) {
+            return false;
+        }
+        if (msg->size != sizeof(msg->data1)) {
+            return false;
+        }
+        break;
+    default:
+        break;
+    }
 
     return true;
 }
diff --git a/remote/memory.c b/remote/memory.c
new file mode 100644
index 0000000000..2c8b7bb42f
--- /dev/null
+++ b/remote/memory.c
@@ -0,0 +1,63 @@
+/*
+ * Memory manager for remote device
+ *
+ * Copyright © 2018, 2020 Oracle and/or its affiliates.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ *
+ */
+
+#include <stdint.h>
+#include <sys/types.h>
+
+#include "qemu/osdep.h"
+#include "qemu/queue.h"
+#include "qemu-common.h"
+#include "remote/memory.h"
+#include "exec/memory.h"
+#include "exec/address-spaces.h"
+#include "cpu.h"
+#include "exec/ram_addr.h"
+#include "io/mpqemu-link.h"
+#include "qemu/main-loop.h"
+#include "qapi/error.h"
+
+void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
+{
+    sync_sysmem_msg_t *sysmem_info = &msg->data1.sync_sysmem;
+    MemoryRegion *sysmem, *subregion, *next;
+    Error *local_err = NULL;
+    int region;
+
+    sysmem = get_system_memory();
+
+    qemu_mutex_lock_iothread();
+
+    memory_region_transaction_begin();
+
+    QTAILQ_FOREACH_SAFE(subregion, &sysmem->subregions, subregions_link, next) {
+        if (subregion->ram) {
+            memory_region_del_subregion(sysmem, subregion);
+            qemu_ram_free(subregion->ram_block);
+        }
+    }
+
+    for (region = 0; region < msg->num_fds; region++) {
+        subregion = g_new(MemoryRegion, 1);
+        qemu_ram_init_from_fd(subregion, msg->fds[region],
+                              sysmem_info->sizes[region],
+                              sysmem_info->offsets[region], &local_err);
+        if (local_err) {
+            error_propagate(errp, local_err);
+            break;
+        }
+
+        memory_region_add_subregion(sysmem, sysmem_info->gpas[region],
+                                    subregion);
+    }
+
+    memory_region_transaction_commit();
+
+    qemu_mutex_unlock_iothread();
+}
-- 
2.25.GIT



  parent reply	other threads:[~2020-04-06  9:47 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06  9:40 [PATCH v6 00/36] Initial support for multi-process qemu elena.ufimtseva
2020-04-06  9:40 ` [PATCH v6 01/36] memory: alloc RAM from file at offset elena.ufimtseva
2020-04-06  9:40 ` [PATCH v6 02/36] multi-process: Refactor machine_init and exit notifiers elena.ufimtseva
2020-04-06  9:40 ` [PATCH v6 03/36] command-line: refractor parser code elena.ufimtseva
2020-04-06  9:40 ` [PATCH v6 04/36] multi-process: Refactor chardev functions out of vl.c elena.ufimtseva
2020-04-06  9:40 ` [PATCH v6 05/36] multi-process: Refactor monitor " elena.ufimtseva
2020-04-06  9:40 ` [PATCH v6 06/36] monitor: destaticize HMP commands elena.ufimtseva
2020-04-09 17:51   ` Dr. David Alan Gilbert
2020-04-06  9:40 ` [PATCH v6 07/36] multi-process: add a command line option for debug file elena.ufimtseva
2020-04-06  9:40 ` [PATCH v6 08/36] multi-process: Add stub functions to facilate build of multi-process elena.ufimtseva
2020-04-06 13:36   ` Eric Blake
2020-04-06  9:40 ` [PATCH v6 09/36] multi-process: Add config option for multi-process QEMU elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 10/36] multi-process: build system for remote device process elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 11/36] multi-process: define mpqemu-link object elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 12/36] multi-process: add functions to synchronize proxy and remote endpoints elena.ufimtseva
2020-04-09 17:56   ` Dr. David Alan Gilbert
2020-04-06  9:41 ` [PATCH v6 13/36] multi-process: setup PCI host bridge for remote device elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 14/36] multi-process: setup a machine object for remote device process elena.ufimtseva
2020-04-06  9:41 ` elena.ufimtseva [this message]
2020-04-06  9:41 ` [PATCH v6 16/36] multi-process: remote process initialization elena.ufimtseva
2020-04-09 18:00   ` Dr. David Alan Gilbert
2020-04-10  8:22     ` Elena Ufimtseva
2020-04-06  9:41 ` [PATCH v6 17/36] multi-process: introduce proxy object elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 18/36] multi-process: Initialize Proxy Object's communication channel elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 19/36] multi-process: Connect Proxy Object with device in the remote process elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 20/36] multi-process: Forward PCI config space acceses to " elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 21/36] multi-process: PCI BAR read/write handling for proxy & remote endpoints elena.ufimtseva
2020-04-09 18:55   ` Dr. David Alan Gilbert
2020-04-06  9:41 ` [PATCH v6 22/36] multi-process: Synchronize remote memory elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 23/36] multi-process: create IOHUB object to handle irq elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 24/36] multi-process: Retrieve PCI info from remote process elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 25/36] multi-process: Introduce build flags to separate remote process code elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 26/36] multi-process: add parse_cmdline in remote process elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 27/36] multi-process: add support to parse device option elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 28/36] multi-process: send heartbeat messages to remote elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 29/36] multi-process: handle heartbeat messages in remote process elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 30/36] multi-process: perform device reset in the " elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 31/36] multi-process/mon: choose HMP commands based on target elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 32/36] multi-process/mon: stub functions to enable QMP module for remote process elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 33/36] multi-process/mon: enable QMP module support in the " elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 34/36] multi-process/mon: Initialize QMP module for remote processes elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 35/36] multi-process: add the concept description to docs/devel/qemu-multiprocess elena.ufimtseva
2020-04-06  9:41 ` [PATCH v6 36/36] multi-process: add configure and usage information elena.ufimtseva
2020-04-06 10:14 ` [PATCH v6 00/36] Initial support for multi-process qemu no-reply
2020-04-06 16:28   ` Elena Ufimtseva
2020-04-06 10:36 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b1614ac098dd88b32dd06a2d7e17f7d1b85492c.1586165556.git.elena.ufimtseva@oracle.com \
    --to=elena.ufimtseva@oracle.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=fam@euphon.net \
    --cc=felipe@nutanix.com \
    --cc=jag.raman@oracle.com \
    --cc=john.g.johnson@oracle.com \
    --cc=kanth.ghatraju@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=liran.alon@oracle.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    --cc=swapnil.ingle@nutanix.com \
    --cc=thanos.makatos@nutanix.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).