From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EDBECCD194 for ; Thu, 16 Oct 2025 12:08:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v9Mlk-0007y9-2L; Thu, 16 Oct 2025 08:07:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9Mld-0007x6-6e for qemu-devel@nongnu.org; Thu, 16 Oct 2025 08:07:38 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v9MlV-0006pr-Mo for qemu-devel@nongnu.org; Thu, 16 Oct 2025 08:07:34 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3ee64bc6b90so451607f8f.0 for ; Thu, 16 Oct 2025 05:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760616438; x=1761221238; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8nl8+aCVc6MnHi449xOsXy7u+daf8qJov2bS5j31z5E=; b=iBSIjEheruCM2mc7EXJ5p8gAg7jutqV5cQepdK1cFuL0YSXGc2KIUTenBAbdiUinea fNO+U3IX+UU37x2uuR7v6mPeIgLiffiPOJbQ0CEnlTbDxldYZN2Wtfie8SE2+pP/Ywe3 CKcxW8C63D+SF1RThJkSUXMzWQpdRsbmLUZ/BqVX1kV6jVM6jMsFS0Ns5q45NcSKPaF4 PQkXiu+rH0X1mjQZTuEdNZs8rNqBNbUTHrzEy5cCiOeYNhNnUwGONzicVcXcLId5KNaI z1C0rpJK/rxDiTJ1EjqLTvOVO9BsZ+ygOhkkVuE816fpX18X8X6YV4SzFKTQksNCcBU1 MvRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760616438; x=1761221238; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8nl8+aCVc6MnHi449xOsXy7u+daf8qJov2bS5j31z5E=; b=N+9Rh6LhYwWh2YvSg77LOsg4bjzxP1ucIXphsoUdIJ8HGjRb4AN8Q5ysunxXCjp8LG 1pmrlHMDPqvxy58v53yMdZbPp9LX1GnLRcFz/WQqnMy1wtJ1MP+er2WFBAgFmBSBETQc p7nO16+DYd4AoPDs8MG2K1mtGy4aCZKqA71FUL5+mGnqwy4EcK7RS8LMHnDdegpPdBzv OPYodVoWXLayghhYV8F9B993fcUzzDIdlR4QXMztlDWNmtgGIZZCmUMEgod70c/GbBWW IFuuymPfzUn9uKqPLriOgrgZzt/dYIlFer7zpP6s67BAehj673xMmu80AXmoX5mFnF55 /flg== X-Forwarded-Encrypted: i=1; AJvYcCX32Qr+LJwZrU8JBONhvac+aKc2icUgmCaQuKx3E3MqwjbsqTvUmyGHb/kOUPvS4+Hz9AbC0WzvPB8b@nongnu.org X-Gm-Message-State: AOJu0YznFTZjcd0pru7y0aTQtoHnYRge7EW6RiSkPprcxmuA/+NBcvHm LsOaZBGzZDAO50Duxg7eRXzVdOoLwur3/ApgjM7UWtMNnzO5dwVc9j/0x/f6cgmTReQ= X-Gm-Gg: ASbGncvBDBNs3GJBdGgfbIw2yp0gnWUFVPveFXG50qxK9pygfIvzREkMAaBmdlgPZz2 ilkB6DOY0EmceDOS8op0PJOf49rOQkjeKLRRn71FK/kzFVI2kLqkk9zntqBIse+Xuf4vwkUhsJ+ Zh2Sie3RFpQts3miFqmSEKDluc4o/7YwiJX9U8hXUHXph3uFxTlUpztipns+euS33AmW4OJ0AnX z/3k0eIM83Qd37hCbNbs6Nx2zgc2mudlDQaqPtARhJWIUoI1pTV46OXIuEODucZ34URTuvgVob0 e44t26Ip18Crcbsro1I9PUV3fIGLrgSkF5NxgeDRyOZm22tUnqlwujRiZsR8LC3bRAgne2jKSAT 3lWsqFOHRJx6mSmhdZLEspPOtJwm6hD5pYrxI5bYh7GpNF8UTQzlZjLe65GwPSm92exlgl1L7Sk 8u3OTjpQgVMJE3NRlx633+xTE5YMZ6v0ghGE8Wd8U7XQILRqh0QiNzPlq5Pg== X-Google-Smtp-Source: AGHT+IF+gUKvX2um9gIt2ygqlGKR3ctLIlBvcTtGe0sYSWZWeLQvlmodCoil7b1kYlwpX7W7wYLRgw== X-Received: by 2002:a05:6000:2010:b0:402:4142:c7a7 with SMTP id ffacd0b85a97d-42666ac6f35mr23553877f8f.16.1760616437597; Thu, 16 Oct 2025 05:07:17 -0700 (PDT) Received: from [192.168.69.221] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce5cfe74sm33816743f8f.35.2025.10.16.05.07.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Oct 2025 05:07:16 -0700 (PDT) Message-ID: <7b263ac1-b8a8-475c-a59a-23b8d419f6e6@linaro.org> Date: Thu, 16 Oct 2025 14:07:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/16] overall: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org References: <20251010134226.72221-1-philmd@linaro.org> <5e4d3a1a-ee13-40c3-b470-d68f5b6b4ad1@redhat.com> <614c4af0-1fea-4d48-bb52-a1ef60302b9a@linaro.org> In-Reply-To: <614c4af0-1fea-4d48-bb52-a1ef60302b9a@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SUSPICIOUS_RECIPS=2.51, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/10/25 16:37, Philippe Mathieu-Daudé wrote: > On 10/10/25 15:51, Paolo Bonzini wrote: >> On 10/10/25 15:42, Philippe Mathieu-Daudé wrote: >>> Replace compile-time #ifdef with a runtime check to ensure all code >>> paths are built and tested. This reduces build-time configuration >>> complexity and improves maintainability. >>> >>> No functional change intended. >> >> No need to repost (and I didn't review), but please change throughout >> the commit message to mention a *compile-time* if() check.  The code >> for the wrong endianness will not make it past compilation, and >> mentioning runtime checks left me wondering if you had mistaken HOST >> for TARGET. > > I want HOST, and hope the changes are correct: I meant to express the > code is elided by the compiler, indeed not at *runtime* 🤦 I'll reword > the commit description. Thanks for catching this. What about: Replace preprocessor-time #ifdef with a compile-time check to ensure all code paths are built and tested. This reduces build-time configuration complexity and simplifies code maintainability. ?