From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, "Peter Maydell" <peter.maydell@linaro.org>,
berrange@redhat.com, stefanb@linux.vnet.ibm.com,
richard.henderson@linaro.org, f4bug@amsat.org, cota@braap.org,
stefanha@redhat.com, pbonzini@redhat.com,
marcandre.lureau@redhat.com,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
aurelien@aurel32.net
Subject: Re: [PATCH v1 1/5] tests/vm: make --interactive (and therefore DEBUG=1) unconditional
Date: Wed, 13 Nov 2019 14:31:58 +0100 [thread overview]
Message-ID: <7b29d4db-8ea4-5a81-de17-56ae3973ce82@redhat.com> (raw)
In-Reply-To: <20191113115952.775-2-alex.bennee@linaro.org>
On 13/11/2019 12.59, Alex Bennée wrote:
> While the concept of only dropping to ssh if a test fails is nice it
> is more useful for this to be unconditional. You usually just want to
> get the build up and running and then noodle around debugging or
> attempting to replicate.
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> ---
> v2
> - fix spelling
> ---
> tests/vm/basevm.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
> index 91a9226026d..0b8c1b26576 100755
> --- a/tests/vm/basevm.py
> +++ b/tests/vm/basevm.py
> @@ -403,7 +403,7 @@ def main(vmcls):
> exitcode = 0
> if vm.ssh(*cmd) != 0:
> exitcode = 3
> - if exitcode != 0 and args.interactive:
> + if args.interactive:
> vm.ssh()
>
> if not args.snapshot:
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-11-13 13:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 11:59 [PATCH for 4.2-rc2 v1 0/5] misc doc and testing fixes Alex Bennée
2019-11-13 11:59 ` [PATCH v1 1/5] tests/vm: make --interactive (and therefore DEBUG=1) unconditional Alex Bennée
2019-11-13 13:31 ` Thomas Huth [this message]
2019-11-13 11:59 ` [PATCH v1 2/5] docs/devel: rename plugins.rst to tcg-plugins.rst Alex Bennée
2019-11-13 16:23 ` Philippe Mathieu-Daudé
2019-11-13 16:39 ` Paolo Bonzini
2019-11-13 11:59 ` [PATCH v1 3/5] docs/devel: update tcg-plugins.rst with API versioning details Alex Bennée
[not found] ` <SN6PR13MB2272B60021982C8C7F680CAA80760@SN6PR13MB2272.namprd13.prod.outlook.com>
2019-11-13 14:40 ` FW: " Robert Foley
2019-11-13 11:59 ` [PATCH v1 4/5] docs/devel: convert multi-thread-tcg to a .rst document Alex Bennée
2019-11-13 11:59 ` [PATCH v1 5/5] .travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS Alex Bennée
2019-11-13 13:30 ` Thomas Huth
2019-11-19 12:13 ` Thomas Huth
2019-11-13 16:29 ` Philippe Mathieu-Daudé
2019-11-13 17:38 ` [EXTERNAL]Re: " Aleksandar Markovic
2019-11-13 18:44 ` Philippe Mathieu-Daudé
2019-11-13 19:01 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b29d4db-8ea4-5a81-de17-56ae3973ce82@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).