Re: [PATCH] test: make cached assets for functional tests read-only

[Thomas Huth <thuth@redhat.com>]

On 21/10/2024 17.02, Thomas Huth wrote:
> On 21/10/2024 14.36, Daniel P. Berrangé wrote:
>> This ensures that if a functional test runs QEMU with a writable
>> disk pointing to a cached asset, an error will be reported, rather
>> than silently modifying the cache file.
>>
>> As an example, tweaking test_sbsaref.py to set snapshot=off,
>> results in a clear error:
>>
>>    Command: ./build/qemu-system-aarch64 ...snip... -drive file=/var/home/ 
>> berrange/.cache/qemu/ 
>> download/44cdbae275ef1bb6dab1d5fbb59473d4f741e1c8ea8a80fd9e906b531d6ad461,format=raw,snapshot=off -cpu max,pauth=off
>>    Output: qemu-system-aarch64: Could not open '/var/home/berrange/.cache/ 
>> qemu/ 
>> download/44cdbae275ef1bb6dab1d5fbb59473d4f741e1c8ea8a80fd9e906b531d6ad461': Permission denied
>>
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>   tests/functional/qemu_test/asset.py | 3 +++
>>   1 file changed, 3 insertions(+)
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Tested-by: Thomas Huth <thuth@redhat.com>

Actually, if you start with a clean cache, or if you manually do:

  chmod a-w ~/.cache/qemu/download/*

a couple of tests are failing now. Could you please have a look?

  Thanks
   Thomas