From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: r.bolshakov@yadro.com, j@getutm.app
Subject: Re: [PATCH v3 for-6.0 2/2] tcg: Workaround macOS 11.2 mprotect bug
Date: Mon, 22 Mar 2021 09:00:57 -0600 [thread overview]
Message-ID: <7b4307e4-d7ea-f0fa-9d40-8324d37aca5c@linaro.org> (raw)
In-Reply-To: <6155888a-e1af-0a47-a669-1bc12c4478fa@amsat.org>
On 3/22/21 4:03 AM, Philippe Mathieu-Daudé wrote:
>> - rc = qemu_mprotect_none(end, page_size);
>
> What about:
>
> #ifdef CONFIG_DARWIN
>
> /* ... */
> (void)rc;
> #else
>
>> - g_assert(!rc);
>
> #endif
What does that buy us, really? It seems like it just clutters the code with
ifdefs.
r~
next prev parent reply other threads:[~2021-03-22 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 16:57 [PATCH v3 for-6.0 0/2] tcg: Workaround macOS 11.2 mprotect bug Richard Henderson
2021-03-20 16:57 ` [PATCH v3 for-6.0 1/2] tcg: Do not set guard pages on the rx portion of code_gen_buffer Richard Henderson
2021-03-22 13:56 ` Roman Bolshakov
2021-03-22 15:13 ` Richard Henderson
2021-03-20 16:57 ` [PATCH v3 for-6.0 2/2] tcg: Workaround macOS 11.2 mprotect bug Richard Henderson
2021-03-22 10:03 ` Philippe Mathieu-Daudé
2021-03-22 13:47 ` Roman Bolshakov
2021-03-22 15:00 ` Richard Henderson [this message]
2021-03-22 15:39 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b4307e4-d7ea-f0fa-9d40-8324d37aca5c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=j@getutm.app \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).