From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
kvm@vger.kernel.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Kevin Wolf" <kwolf@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>
Subject: Re: [PATCH v5 0/6] target/i386: Restrict system-specific features from user emulation
Date: Wed, 13 Sep 2023 12:29:15 +0200 [thread overview]
Message-ID: <7b544940-0cf2-652e-732e-934dfac63182@redhat.com> (raw)
In-Reply-To: <20230913093009.83520-1-philmd@linaro.org>
On 9/13/23 11:30, Philippe Mathieu-Daudé wrote:
> Since v4:
> - Addressed Paolo's suggestions (clearly better)
>
> Too many system-specific code (and in particular KVM related)
> is pulled in user-only build. This led to adding unjustified
> stubs as kludge to unagressive linker non-optimizations.
>
> This series restrict x86 system-specific features to sysemu,
> so we don't require any stub, and remove all x86 KVM declarations
> from user emulation code (to trigger compile failure instead of
> link one).
I'm still not sure about patch 5, though I'd like to have something like
patch 6. But fortunately patches 1-3 are enough to placate clang, so I
have queued them.
Thanks Philippe!
Paolo
prev parent reply other threads:[~2023-09-13 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 9:30 [PATCH v5 0/6] target/i386: Restrict system-specific features from user emulation Philippe Mathieu-Daudé
2023-09-13 9:30 ` [PATCH v5 1/6] target/i386: Check kvm_hyperv_expand_features() return value Philippe Mathieu-Daudé
2023-09-13 9:30 ` [PATCH v5 2/6] target/i386: Drop accel_uses_host_cpuid before x86_cpu_get_supported_cpuid Philippe Mathieu-Daudé
2023-09-13 9:30 ` [PATCH v5 3/6] target/i386: Call accel-agnostic x86_cpu_get_supported_cpuid() Philippe Mathieu-Daudé
2023-09-13 10:59 ` Michael Tokarev
2023-09-13 11:01 ` Philippe Mathieu-Daudé
2023-09-13 9:30 ` [PATCH v5 4/6] target/i386: Move x86_cpu_get_migratable_flags() around Philippe Mathieu-Daudé
2023-09-13 9:30 ` [RFC PATCH v5 5/6] target/i386: Restrict system-specific code from user emulation Philippe Mathieu-Daudé
2023-09-13 9:30 ` [PATCH v5 6/6] target/i386: Prohibit target specific KVM prototypes on " Philippe Mathieu-Daudé
2023-09-13 10:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b544940-0cf2-652e-732e-934dfac63182@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=dbarboza@ventanamicro.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mtosatti@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).