From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Claudio Fontana" <cfontana@suse.de>,
qemu-ppc@nongnu.org, qemu-s390x@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-riscv@nongnu.org, "Brian Cain" <bcain@quicinc.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-arm@nongnu.org,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Anton Johansson" <anjo@rev.ng>, "Warner Losh" <imp@bsdimp.com>
Subject: Re: [PATCH v2 19/23] exec/user: Do not include 'cpu.h' in 'abitypes.h'
Date: Thu, 14 Dec 2023 19:30:14 +0100 [thread overview]
Message-ID: <7b576994-9477-4b84-aa12-7e36d90e7529@redhat.com> (raw)
In-Reply-To: <20231212123401.37493-20-philmd@linaro.org>
On 12/12/2023 13.33, Philippe Mathieu-Daudé wrote:
> "exec/user/abitypes.h" requires:
>
> - "exec/cpu-defs.h" (TARGET_LONG_BITS)
> - "exec/tswap.h" (tswap32)
>
> In order to avoid "cpu.h", pick the minimum required headers.
>
> Assert this user-specific header is only included from user
> emulation.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/exec/user/abitypes.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-12-14 18:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 12:33 [PATCH v2 00/23] exec: Rework of various headers (user focused) Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 01/23] exec: Include 'cpu.h' before validating CPUArchState placement Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 02/23] exec: Expose 'target_page.h' API to user emulation Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 03/23] target: Define TCG_GUEST_DEFAULT_MO in 'cpu-param.h' Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 04/23] accel: Include missing 'exec/cpu_ldst.h' header Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 05/23] gdbstub: Include missing 'hw/core/cpu.h' header Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 06/23] semihosting/uaccess: Avoid including 'cpu.h' Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 07/23] semihosting/guestfd: Remove unused 'semihosting/uaccess.h' header Philippe Mathieu-Daudé
2023-12-13 10:58 ` Anton Johansson via
2023-12-12 12:33 ` [PATCH v2 08/23] host/load-extract: Include missing 'qemu/atomic.h' and 'qemu/int128.h' Philippe Mathieu-Daudé
2023-12-13 11:46 ` Anton Johansson via
2023-12-12 12:33 ` [PATCH v2 09/23] host/atomic128: Include missing 'qemu/atomic.h' header Philippe Mathieu-Daudé
2023-12-13 11:56 ` Anton Johansson via
2023-12-12 12:33 ` [PATCH v2 10/23] target/i386: Include missing 'exec/exec-all.h' header Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 11/23] accel/tcg: Include missing 'hw/core/cpu.h' header Philippe Mathieu-Daudé
2023-12-13 13:38 ` Anton Johansson via
2023-12-12 12:33 ` [PATCH v2 12/23] exec/cpu-all: Remove unused 'qemu/thread.h' header Philippe Mathieu-Daudé
2023-12-13 13:44 ` Anton Johansson via
2023-12-12 12:33 ` [PATCH v2 13/23] exec/cpu-all: Reduce 'qemu/rcu.h' header inclusion Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 14/23] exec/cpu-all: Remove unused tswapls() definitions Philippe Mathieu-Daudé
2023-12-13 13:44 ` Anton Johansson via
2023-12-12 12:33 ` [PATCH v2 15/23] exec: Declare target_words_bigendian() in 'exec/tswap.h' Philippe Mathieu-Daudé
2023-12-13 11:20 ` Anton Johansson via
2023-12-13 15:13 ` Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 16/23] exec: Move [b]tswapl() declarations to 'exec/user/tswap-target.h' Philippe Mathieu-Daudé
2023-12-13 13:45 ` Anton Johansson via
2023-12-12 12:33 ` [PATCH v2 17/23] target/ppc/excp_helper: Avoid 'abi_ptr' in system emulation Philippe Mathieu-Daudé
2023-12-14 18:27 ` Thomas Huth
2023-12-12 12:33 ` [PATCH v2 18/23] accel/tcg: Un-inline retaddr helpers to 'user-retaddr.h' Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 19/23] exec/user: Do not include 'cpu.h' in 'abitypes.h' Philippe Mathieu-Daudé
2023-12-14 18:30 ` Thomas Huth [this message]
2023-12-12 12:33 ` [PATCH v2 20/23] exec: Declare abi_ptr type in its own 'abi_ptr.h' header Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 21/23] exec/cpu-all: Restrict inclusion of 'exec/user/guest-base.h' Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 22/23] exec/cpu-all: Extract page-protection definitions to page-prot-common.h Philippe Mathieu-Daudé
2023-12-12 12:33 ` [PATCH v2 23/23] exec/cpu_ldst: Avoid including 'cpu.h' Philippe Mathieu-Daudé
2023-12-12 12:41 ` [PATCH v2 00/23] exec: Rework of various headers (user focused) Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b576994-9477-4b84-aa12-7e36d90e7529@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=cfontana@suse.de \
--cc=imp@bsdimp.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).