From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Sriram Yagnaraman" <sriram.yagnaraman@ericsson.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Luigi Rizzo" <rizzo@iet.unipi.it>,
"Giuseppe Lettieri" <g.lettieri@iet.unipi.it>,
"Vincenzo Maffione" <v.maffione@gmail.com>,
"Andrew Melnychenko" <andrew@daynix.com>,
"Yuri Benditovich" <yuri.benditovich@daynix.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 0/4] virtio-net: Convert feature properties to OnOffAuto
Date: Sun, 14 Jul 2024 14:14:44 +0900 [thread overview]
Message-ID: <7b57d5f8-c398-46c7-b317-fa37e8b43dc8@daynix.com> (raw)
In-Reply-To: <CACGkMEsrY84aW9w1zef-6KaTYaKuJ_mBqVxJbLuettORmB7oBw@mail.gmail.com>
On 2024/07/09 11:52, Jason Wang wrote:
> On Mon, Jul 8, 2024 at 3:38 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>>
>> Based-on: <20240428-rss-v10-0-73cbaa91aeb6@daynix.com>
>> ("[PATCH v10 00/18] virtio-net RSS/hash report fixes and improvements")
>>
>> Some features are not always available, and virtio-net used to disable
>> them when not available even if the corresponding properties were
>> explicitly set to "on".
>>
>> Convert feature properties to OnOffAuto so that the user can explicitly
>> tell QEMU to automatically select the value by setting them "auto".
>> QEMU will give an error if they are set "on".
>
> Would this be consumed by a management layer like libvirt?
No, as far as I know. I couldn't find any code that consumes the feature
values and the patched binary worked with rss="on".
Regards,
Akihiko Odaki
prev parent reply other threads:[~2024-07-14 5:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 7:38 [PATCH v2 0/4] virtio-net: Convert feature properties to OnOffAuto Akihiko Odaki
2024-07-08 7:38 ` [PATCH v2 1/4] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64() Akihiko Odaki
2024-07-08 10:43 ` Michael S. Tsirkin
2024-07-10 14:06 ` Daniel P. Berrangé
2024-07-08 7:38 ` [PATCH v2 2/4] virtio-net: Convert feature properties to OnOffAuto Akihiko Odaki
2024-07-08 7:38 ` [PATCH v2 3/4] virtio-net: Report RSS warning at device realization Akihiko Odaki
2024-07-08 7:38 ` [PATCH v2 4/4] virtio-net: Remove fallback from ebpf-rss-fds Akihiko Odaki
2024-07-10 14:16 ` Daniel P. Berrangé
2024-07-09 2:52 ` [PATCH v2 0/4] virtio-net: Convert feature properties to OnOffAuto Jason Wang
2024-07-14 5:14 ` Akihiko Odaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b57d5f8-c398-46c7-b317-fa37e8b43dc8@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=andrew@daynix.com \
--cc=berrange@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=eduardo@habkost.net \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=sriram.yagnaraman@ericsson.com \
--cc=v.maffione@gmail.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).