From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Roman Bolshakov <rbolshakov@ddn.com>,
qemu-arm@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
Alexander Graf <agraf@csgraf.de>,
xen-devel@lists.xenproject.org,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Anthony Perard <anthony.perard@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Yanan Wang <wangyanan55@huawei.com>, Paul Durrant <paul@xen.org>,
Reinoud Zandijk <reinoud@netbsd.org>,
Eduardo Habkost <eduardo@habkost.net>,
Cameron Esfahani <dirty@apple.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 16/16] accel: Rename HVF 'struct hvf_vcpu_state' -> AccelCPUState
Date: Tue, 27 Jun 2023 14:43:26 +0200 [thread overview]
Message-ID: <7b6c659f-a9d3-c883-ff53-3226c8d31bb8@linaro.org> (raw)
In-Reply-To: <20230624174121.11508-17-philmd@linaro.org>
On 24/6/23 19:41, Philippe Mathieu-Daudé wrote:
> We want all accelerators to share the same opaque pointer in
> CPUState.
>
> Rename the 'hvf_vcpu_state' structure as 'AccelCPUState'.
>
> Use the generic 'accel' field of CPUState instead of 'hvf'.
>
> Replace g_malloc0() by g_new0() for readability.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> Not even built on x86!
Per IRC chat:
Tested-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/core/cpu.h | 4 -
> include/sysemu/hvf_int.h | 2 +-
> target/i386/hvf/vmx.h | 22 ++--
> accel/hvf/hvf-accel-ops.c | 18 ++--
> target/arm/hvf/hvf.c | 108 +++++++++----------
> target/i386/hvf/hvf.c | 104 +++++++++---------
> target/i386/hvf/x86.c | 28 ++---
> target/i386/hvf/x86_descr.c | 26 ++---
> target/i386/hvf/x86_emu.c | 62 +++++------
> target/i386/hvf/x86_mmu.c | 4 +-
> target/i386/hvf/x86_task.c | 10 +-
> target/i386/hvf/x86hvf.c | 208 ++++++++++++++++++------------------
> 12 files changed, 296 insertions(+), 300 deletions(-)
next prev parent reply other threads:[~2023-06-27 12:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 17:41 [PATCH v3 00/16] accel: Share CPUState accel context (HAX/NVMM/WHPX/HVF) Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 01/16] MAINTAINERS: Update Roman Bolshakov email address Philippe Mathieu-Daudé
2023-06-28 6:19 ` Roman Bolshakov
2023-06-24 17:41 ` [PATCH v3 02/16] accel: Document generic accelerator headers Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 03/16] accel: Remove unused hThread variable on TCG/WHPX Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 04/16] accel: Fix a leak on Windows HAX Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 05/16] accel: Destroy HAX vCPU threads once done Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 06/16] accel: Rename 'hax_vcpu' as 'accel' in CPUState Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 07/16] accel: Rename HAX 'struct hax_vcpu_state' -> AccelCPUState Philippe Mathieu-Daudé
2023-06-26 10:10 ` Richard Henderson
2023-06-24 17:41 ` [PATCH v3 08/16] accel: Move HAX hThread to accelerator context Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 09/16] accel: Remove NVMM unreachable error path Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 10/16] accel: Rename NVMM 'struct qemu_vcpu' -> AccelCPUState Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 11/16] accel: Inline NVMM get_qemu_vcpu() Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 12/16] accel: Remove WHPX unreachable error path Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 13/16] accel: Rename WHPX 'struct whpx_vcpu' -> AccelCPUState Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 14/16] accel: Inline WHPX get_whpx_vcpu() Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 15/16] accel: Rename 'cpu_state' -> 'cs' Philippe Mathieu-Daudé
2023-06-27 12:43 ` Philippe Mathieu-Daudé
2023-06-24 17:41 ` [PATCH v3 16/16] accel: Rename HVF 'struct hvf_vcpu_state' -> AccelCPUState Philippe Mathieu-Daudé
2023-06-27 12:43 ` Philippe Mathieu-Daudé [this message]
2023-06-27 15:13 ` [PATCH v3 00/16] accel: Share CPUState accel context (HAX/NVMM/WHPX/HVF) Philippe Mathieu-Daudé
2023-06-28 11:58 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b6c659f-a9d3-c883-ff53-3226c8d31bb8@linaro.org \
--to=philmd@linaro.org \
--cc=agraf@csgraf.de \
--cc=anthony.perard@citrix.com \
--cc=dirty@apple.com \
--cc=eduardo@habkost.net \
--cc=kvm@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=reinoud@netbsd.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=sunilmut@microsoft.com \
--cc=wangyanan55@huawei.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).