From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/rx: Use target_ulong for address in LI
Date: Wed, 24 Jul 2024 08:15:06 +0200 [thread overview]
Message-ID: <7b724d3a-4fda-4827-828b-ece69835e9f5@redhat.com> (raw)
In-Reply-To: <20240724045659.160684-1-richard.henderson@linaro.org>
On 24/07/2024 06.56, Richard Henderson wrote:
> Using int32_t meant that the address was sign-extended to uint64_t
> when passing to translator_ld*, triggering an assert.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2453
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/rx/translate.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/rx/translate.c b/target/rx/translate.c
> index 9b81cf20b3..9aade2b6e5 100644
> --- a/target/rx/translate.c
> +++ b/target/rx/translate.c
> @@ -85,7 +85,8 @@ static uint32_t decode_load_bytes(DisasContext *ctx, uint32_t insn,
>
> static uint32_t li(DisasContext *ctx, int sz)
> {
> - int32_t tmp, addr;
> + target_ulong addr;
> + uint32_t tmp;
> CPURXState *env = ctx->env;
> addr = ctx->base.pc_next;
>
Thank you very much! This fixes the problem for me.
Tested-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2024-07-24 6:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 4:56 [PATCH] target/rx: Use target_ulong for address in LI Richard Henderson
2024-07-24 6:15 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b724d3a-4fda-4827-828b-ece69835e9f5@redhat.com \
--to=thuth@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).