From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D2C0C3DA63 for ; Wed, 24 Jul 2024 06:15:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWVHX-0004WE-Vj; Wed, 24 Jul 2024 02:15:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWVHT-0004IX-5S for qemu-devel@nongnu.org; Wed, 24 Jul 2024 02:15:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWVHR-0006oz-7g for qemu-devel@nongnu.org; Wed, 24 Jul 2024 02:15:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721801716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NFeIHV39XxZS6NgF/APMFIwAev8YmBgtv5TuiZ0KA2A=; b=NL8MflELoqeq64CKvndk5ozs96M+HxklfoVScnrFXh9RYKQ5IGJDGiHIYH4H6FzCklxK/4 IPvNxjwJYHjpFO9YN2Mbhw6gmlgy2zqQ+iUh/c+sGxiCvJFweZYRLRO0CpxPFg2wTfbH57 xnzSgaRY9w6c5iF4bpF1Bh03QpKbEzs= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-wOdJD6KFMjyhu-Q4b7Eu9A-1; Wed, 24 Jul 2024 02:15:09 -0400 X-MC-Unique: wOdJD6KFMjyhu-Q4b7Eu9A-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-52f00bde29dso4113202e87.3 for ; Tue, 23 Jul 2024 23:15:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721801708; x=1722406508; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NFeIHV39XxZS6NgF/APMFIwAev8YmBgtv5TuiZ0KA2A=; b=Rl7AdLFZl1LyCagoKCGXgzr8jLTCcy6G4/xUMqCE/Y9fS1J1X77S/ETzra/ndtgX7g AJo/J+oCtJ0yARtOHfMhQR0Vk6lg6b6Vi4lNOrMPKnxDIGaP9r000GmLpfSZ359dHq8K 4LmteDzufB+T5Rjt5K7/29kqVFuhuRDMDlvMPXYvLEi0G5HI6N6wKfZy6O81w+wZx/XD fIddegF/u3eYjq7BboBq4AUIdkpoP0/r5pG5usmqP25aG0VmjfcMqQsT8nkoCHUaq6UQ or+il7eA/0xJ2BP+YNJ3zoEybUyTtBT2rFVbLjvP0pemo3DZI/8NXeK0c8EbjeZhLlsk UHpQ== X-Forwarded-Encrypted: i=1; AJvYcCVpBIQ+4Ib4mleSKUfJmNYTZBDF1wzvOrPHBWG1BgVA5M4X34vttepPOYK07mdk7tFzRmDvm7MwY0EzDmGFr6UR0i4Gc4I= X-Gm-Message-State: AOJu0YwbxGB4aeK19VeB6DSfuZh9dZgYCmGokmOLEDjoeiQwgEX4r0Rk V31DrH/R0rq14zAM1wjkEUQqPNuRxzDBVKQwITRHVXMhJsoZA/G6AQ2F7cvZ/Z1fyBKdk71wNPD /GifHO8QzUm80vkCnDp11bMEu6I+YDMy0qUkr9WJ2p/vl+yj05Hv3oUs9kcRr X-Received: by 2002:a05:6512:10d5:b0:52c:e05f:9052 with SMTP id 2adb3069b0e04-52fcda9b503mr1216781e87.47.1721801708345; Tue, 23 Jul 2024 23:15:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnMe/9g00jaHdHc37HOPq/Nfuzc/qyPkfkXNaNmtyjOw4egKG9gzgUjKHEyQhRQXQRRQqFxQ== X-Received: by 2002:a05:6512:10d5:b0:52c:e05f:9052 with SMTP id 2adb3069b0e04-52fcda9b503mr1216755e87.47.1721801707849; Tue, 23 Jul 2024 23:15:07 -0700 (PDT) Received: from [192.168.0.4] (ip-109-43-178-36.web.vodafone.de. [109.43.178.36]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7aa3a6a599sm101991666b.222.2024.07.23.23.15.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jul 2024 23:15:07 -0700 (PDT) Message-ID: <7b724d3a-4fda-4827-828b-ece69835e9f5@redhat.com> Date: Wed, 24 Jul 2024 08:15:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] target/rx: Use target_ulong for address in LI To: Richard Henderson , qemu-devel@nongnu.org References: <20240724045659.160684-1-richard.henderson@linaro.org> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240724045659.160684-1-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.133, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 24/07/2024 06.56, Richard Henderson wrote: > Using int32_t meant that the address was sign-extended to uint64_t > when passing to translator_ld*, triggering an assert. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2453 > Signed-off-by: Richard Henderson > --- > target/rx/translate.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/rx/translate.c b/target/rx/translate.c > index 9b81cf20b3..9aade2b6e5 100644 > --- a/target/rx/translate.c > +++ b/target/rx/translate.c > @@ -85,7 +85,8 @@ static uint32_t decode_load_bytes(DisasContext *ctx, uint32_t insn, > > static uint32_t li(DisasContext *ctx, int sz) > { > - int32_t tmp, addr; > + target_ulong addr; > + uint32_t tmp; > CPURXState *env = ctx->env; > addr = ctx->base.pc_next; > Thank you very much! This fixes the problem for me. Tested-by: Thomas Huth