From: Richard Henderson <richard.henderson@linaro.org>
To: matheus.ferst@eldorado.org.br, qemu-devel@nongnu.org,
qemu-ppc@nongnu.org
Cc: groug@kaod.org, david@gibson.dropbear.id.au
Subject: Re: [RFC PATCH] target/ppc: fix vector registers access in gdbstub for little-endian
Date: Thu, 12 Aug 2021 10:05:52 -1000 [thread overview]
Message-ID: <7b8530e0-4dc8-ea7f-3cac-e6ae623e6770@linaro.org> (raw)
In-Reply-To: <20210812191007.70331-1-matheus.ferst@eldorado.org.br>
On 8/12/21 9:10 AM, matheus.ferst@eldorado.org.br wrote:
> static bool avr_need_swap(CPUPPCState *env)
> {
> + bool le;
> +#if defined(CONFIG_USER_ONLY)
> + le = false;
> +#else
> + le = msr_le;
> +#endif
It certainly doesn't seem like the right fix.
My first guess was that MSR_LE wasn't being properly set up at cpu_reset for user-only,
but it's there.
r~
next prev parent reply other threads:[~2021-08-12 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 19:10 [RFC PATCH] target/ppc: fix vector registers access in gdbstub for little-endian matheus.ferst
2021-08-12 20:05 ` Richard Henderson [this message]
2021-08-13 9:17 ` Peter Maydell
2021-08-16 12:17 ` Matheus K. Ferst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b8530e0-4dc8-ea7f-3cac-e6ae623e6770@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).