Re: [PATCH v2] audio: Add sndio backend

[WANG Xuerui <i.qemu@xen0n.name>]

Hi Alexandre,

On 12/17/21 17:38, Alexandre Ratchov wrote:
> sndio is the native API used by OpenBSD, although it has been ported to
> other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
> Signed-off-by: Alexandre Ratchov <alex@caoua.org>
> ---
>
> Thank you for the reviews and all the comments. Here's a second diff
> with all the suggested changes:
>
> - Replace ISC license by SPDX-License-Identifier header
> - Fix units (milli- vs micro-) in comment about SNDIO_LATENCY_US
> - Drop outdated comment about the "size" argument of sndio_get_buffer_out()
> - Fix AUDIO_FORMAT_U32 handling (missing "break" statement)
> - Set {read,write] methods to audio_generic_{read,write} (fixes craches)
> - Check if backend is enabled in sndio_poll_event()
> - Use https://sndio.org in description
> - Mark options as available after 7.0 release (instead of 6.2)
> - Describe sndio-specific options (dev, latency) in qemu-options.hx
> - Add myself as reviewer to MAINTAINERS
> - Style fixes: no space after function names, use 4-space indent
> - Don't use "return foo()" if foo() returns void
> - Include backend to audio_drivers_priority[]
>
> Tested on OpenBSD, works as expected!
>
>   MAINTAINERS            |   5 +
>   audio/audio.c          |   1 +
>   audio/audio_template.h |   2 +
>   audio/meson.build      |   1 +
>   audio/sndioaudio.c     | 555 +++++++++++++++++++++++++++++++++++++++++
Here we can see the file added is named "sndioaudio.c", so...
>   meson.build            |   9 +-
>   meson_options.txt      |   4 +-
>   qapi/audio.json        |  25 +-
>   qemu-options.hx        |  16 ++
>   tests/vm/freebsd       |   3 +
>   10 files changed, 618 insertions(+), 3 deletions(-)
>   create mode 100644 audio/sndioaudio.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7543eb4d59..76bdad064f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2307,6 +2307,7 @@ X: audio/jackaudio.c
>   X: audio/ossaudio.c
>   X: audio/paaudio.c
>   X: audio/sdlaudio.c
> +X: audio/sndio.c
it should say "sndioaudio.c" here...
>   X: audio/spiceaudio.c
>   F: qapi/audio.json
>   
> @@ -2349,6 +2350,10 @@ R: Thomas Huth <huth@tuxfamily.org>
>   S: Odd Fixes
>   F: audio/sdlaudio.c
>   
> +Sndio Audio backend
> +R: Alexandre Ratchov <alex@caoua.org>
> +F: audio/sndio.c
and here.
> +
>   Block layer core
>   M: Kevin Wolf <kwolf@redhat.com>
>   M: Hanna Reitz <hreitz@redhat.com>