From: Paul Durrant <xadimgnik@gmail.com>
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com,
Stefano Stabellini <sstabellini@kernel.org>,
Anthony Perard <anthony.perard@citrix.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
"open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c
Date: Wed, 19 Oct 2022 17:16:41 +0100 [thread overview]
Message-ID: <7b8e645c-90c7-a4ff-4405-51df6df2e508@xen.org> (raw)
In-Reply-To: <20221015050750.4185-7-vikram.garhwal@amd.com>
On 15/10/2022 06:07, Vikram Garhwal wrote:
[snip]
> + qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state);
> +
> + state->memory_listener = xen_memory_listener;
> + memory_listener_register(&state->memory_listener, &address_space_memory);
> +
> + state->io_listener = xen_io_listener;
> + memory_listener_register(&state->io_listener, &address_space_io);
> +
> + state->device_listener = xen_device_listener;
> + QLIST_INIT(&state->dev_list);
> + device_listener_register(&state->device_listener);
> +
As Julien said, these do not belong here. These are the (current and
legacy) PV backend setup functions; they most certainly have nothing to
do with device emulation.
Paul
next prev parent reply other threads:[~2022-10-19 16:26 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 5:07 [PATCH v1 00/12] Introduce xenpv machine for arm architecture Vikram Garhwal
2022-10-15 5:07 ` [PATCH v1 01/12] hw/xen: Correct build config for xen_pt_stub Vikram Garhwal
2022-10-19 14:46 ` Paul Durrant
2022-10-26 19:01 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 02/12] hw/i386/xen/: move xen-mapcache.c to hw/xen/ Vikram Garhwal
2022-10-19 14:53 ` Paul Durrant
2022-12-01 20:25 ` Garhwal, Vikram
2022-10-15 5:07 ` [PATCH v1 03/12] hw/i386/xen: rearrange xen_hvm_init_pc Vikram Garhwal
2022-10-19 14:59 ` Paul Durrant
2022-10-15 5:07 ` [PATCH v1 04/12] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState Vikram Garhwal
2022-10-19 15:56 ` Paul Durrant
2022-10-19 16:00 ` Paul Durrant
2022-10-27 8:59 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 05/12] hw/i386/xen/xen-hvm: create arch_handle_ioreq and arch_xen_set_memory Vikram Garhwal
2022-10-19 16:09 ` Paul Durrant
2022-10-27 9:02 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c Vikram Garhwal
2022-10-16 18:07 ` Julien Grall
2022-10-19 16:16 ` Paul Durrant [this message]
2022-10-19 23:12 ` Garhwal, Vikram
2022-10-15 5:07 ` [PATCH v1 07/12] include/hw/xen/xen_common: return error from xen_create_ioreq_server Vikram Garhwal
2022-10-16 17:53 ` Julien Grall
2022-10-15 5:07 ` [PATCH v1 08/12] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure Vikram Garhwal
2022-10-27 8:46 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_dm_state Vikram Garhwal
2022-10-19 16:20 ` Paul Durrant
2022-10-27 9:14 ` Alex Bennée
2022-10-28 20:26 ` Oleksandr Tyshchenko
2022-10-29 5:36 ` Vikram Garhwal
2022-10-29 5:22 ` Garhwal, Vikram
2022-11-01 11:29 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 10/12] hw/arm: introduce xenpv machine Vikram Garhwal
2022-10-16 17:47 ` Julien Grall
2022-10-18 1:26 ` Stefano Stabellini
2022-10-18 8:24 ` Julien Grall
2022-10-19 0:15 ` Stefano Stabellini
2022-10-19 9:49 ` Julien Grall
2022-10-27 8:37 ` Alex Bennée
2022-12-02 3:24 ` Garhwal, Vikram
2022-12-02 9:53 ` Julien Grall
2022-10-27 8:02 ` Alex Bennée
2022-10-28 17:57 ` Julien Grall
2022-10-28 19:05 ` Oleksandr Tyshchenko
2022-10-27 8:40 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 11/12] meson.build: enable xenpv machine build for ARM Vikram Garhwal
2022-10-27 9:11 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 12/12] meson.build: do not set have_xen_pci_passthrough for aarch64 targets Vikram Garhwal
2022-10-27 9:14 ` Alex Bennée
2022-10-27 8:26 ` [PATCH v1 00/12] Introduce xenpv machine for arm architecture Alex Bennée
2022-10-27 9:24 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b8e645c-90c7-a4ff-4405-51df6df2e508@xen.org \
--to=xadimgnik@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=vikram.garhwal@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).