From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, michael.roth@amd.com,
jsnow@redhat.com, hreitz@redhat.com, kwolf@redhat.com,
pbonzini@redhat.com
Subject: Re: [PATCH v6 0/7] trace qmp commands
Date: Thu, 27 Jan 2022 12:41:19 +0300 [thread overview]
Message-ID: <7b974340-4f9c-274c-2218-6b379a557d2e@virtuozzo.com> (raw)
In-Reply-To: <87sft9vdkk.fsf@dusky.pond.sub.org>
27.01.2022 10:32, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>
>> This series aims to add trace points for each qmp command with help of
>> qapi code generator.
>
> Logging QMP traffic has worked well enough for me, but I can understand
> why you'd like to use tracing. Other uses of tracing might come up in
> the future.
>
> I found a few last nits to pick. Happy to address them in my tree.
That would be great, thanks a lot!
>
> Except for PATCH 4
It has "Acked-by: Paolo", so seems we are done.
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
Thanks!
--
Best regards,
Vladimir
next prev parent reply other threads:[~2022-01-27 9:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 16:11 [PATCH v6 0/7] trace qmp commands Vladimir Sementsov-Ogievskiy
2022-01-26 16:11 ` [PATCH v6 1/7] qapi/gen: Add FOO.trace-events output module Vladimir Sementsov-Ogievskiy
2022-01-26 16:11 ` [PATCH v6 2/7] qapi/commands: refactor error handling code Vladimir Sementsov-Ogievskiy
2022-01-26 16:11 ` [PATCH v6 3/7] qapi/commands: Optionally generate trace for QMP commands Vladimir Sementsov-Ogievskiy
2022-01-27 7:24 ` Markus Armbruster
2022-01-27 9:42 ` Vladimir Sementsov-Ogievskiy
2022-01-26 16:11 ` [PATCH v6 4/7] meson: generate trace events for qmp commands Vladimir Sementsov-Ogievskiy
2022-01-26 16:11 ` [PATCH v6 5/7] docs/qapi-code-gen: update to cover trace events code generation Vladimir Sementsov-Ogievskiy
2022-01-27 8:20 ` Stefan Hajnoczi
2022-01-26 16:11 ` [PATCH v6 6/7] meson: document, why we don't generate trace events for tests/ and qga/ Vladimir Sementsov-Ogievskiy
2022-01-27 6:50 ` Markus Armbruster
2022-01-27 9:26 ` Vladimir Sementsov-Ogievskiy
2022-01-27 6:51 ` Markus Armbruster
2022-01-27 8:21 ` Stefan Hajnoczi
2022-01-26 16:11 ` [PATCH v6 7/7] qapi: generate trace events by default Vladimir Sementsov-Ogievskiy
2022-01-27 7:32 ` [PATCH v6 0/7] trace qmp commands Markus Armbruster
2022-01-27 9:41 ` Vladimir Sementsov-Ogievskiy [this message]
2022-01-27 11:10 ` Markus Armbruster
2022-01-27 8:21 ` Stefan Hajnoczi
2022-01-27 9:41 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b974340-4f9c-274c-2218-6b379a557d2e@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).