From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45535)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bCOCQ-00040R-1Y
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 05:30:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bCOCM-0008DH-MF
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 05:30:25 -0400
References: <1465495115-24665-1-git-send-email-sergey.fedorov@linaro.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <7b9be9cb-0e90-bc03-6fac-4bccf90880dd@redhat.com>
Date: Mon, 13 Jun 2016 11:30:16 +0200
MIME-Version: 1.0
In-Reply-To: <1465495115-24665-1-git-send-email-sergey.fedorov@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix tag file generation targets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <sergey.fedorov@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, patches@linaro.org, Sergey Fedorov <serge.fdrv@gmail.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, "Daniel P. Berrange" <berrange@redhat.com>, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>



On 09/06/2016 19:58, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
> 
> "ctags" produces a file named "tags", not "ctags". It doesn't look
> reasonable to use phony target name as a file name to remove. Just use
> exact file names to remove in "ctags" and "TAGS" target receipts.
> 
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index b8563db68677..61bf1bf9e2bb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -478,12 +478,12 @@ test speed: all
>  
>  .PHONY: ctags
>  ctags:
> -	rm -f $@
> +	rm -f tags
>  	find "$(SRC_PATH)" -name '*.[hc]' -exec ctags --append {} +
>  
>  .PHONY: TAGS
>  TAGS:
> -	rm -f $@
> +	rm -f TAGS
>  	find "$(SRC_PATH)" -name '*.[hc]' -exec etags --append {} +
>  
>  cscope:
> 

Queued, thanks.

Paolo