qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: jsnow@redhat.com
Subject: Re: [PATCH] scripts/device-crash-test: ERROR_RULE_LIST garbage collection
Date: Thu, 27 Nov 2025 16:29:07 +0100	[thread overview]
Message-ID: <7ba134db-bf51-491b-91a1-588e4495b387@redhat.com> (raw)
In-Reply-To: <20251127144954.3023865-1-armbru@redhat.com>

On 27/11/2025 15.49, Markus Armbruster wrote:
> Device 'nand' was dropped in commit commit e86c1f967a3.
> 
> Device 'vfio-amd-xgbe' was dropped in commit aeb1a50d4a7.
> 
> Device 'vfio-calxeda-xgmac' was dropped in commit 8ebc416ac17.
> 
> The last error messages matching r"images* must be given with the
> 'pflash' parameter" was dropped in commit a2ccff4d2bc.
> 
> The error message matching r"Option '-device [\w.,-]+' cannot be
> handled by this machine" was dropped in commit commit db78a605599.
> 
> As far as I can tell, we never had message matching r"Ignoring
> smp_cpus value"

This was a wrapped string, it has been changed in comnit 
f2ad5140fa521bda30b9c3c3db5b6913f6dda1ae ("hw/arm/exynos: Convert fprintf to 
qemu_log_mask/error_report") and finally been removed in commit
7264961934130df50d151def5eb415efa2e28ec5.

> or r"MSI-X support is mandatory in the S390
> architecture".

This (split) string still exists in hw/s390x/s390-pci-bus.c:

$ grep -r -A1 MSI-X.support.is.mandatory hw/
hw/s390x/s390-pci-bus.c:            error_setg(errp, "MSI-X support is 
mandatory "
hw/s390x/s390-pci-bus.c-                       "in the S390 architecture");

So I think we should keep it.

  Thomas



  reply	other threads:[~2025-11-27 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-27 14:49 [PATCH] scripts/device-crash-test: ERROR_RULE_LIST garbage collection Markus Armbruster
2025-11-27 15:29 ` Thomas Huth [this message]
2025-11-28  9:59   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ba134db-bf51-491b-91a1-588e4495b387@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).